Kibana query language autocomplete #15945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
:Discovery
Feature:Query Bar
Bargs
reviewed
Mar 21, 2018
| } | ||
|
|
||
| function resolver(query, field) { | ||
| return `${query}/${field.name}`; |
There was a problem hiding this comment.
Should this include the index pattern id as well? Otherwise I think two different index patterns with a field that happens to have a matching name could get stale suggestions.
Bargs
approved these changes
Mar 21, 2018
|
Pending a green CI, this looks great to me! |
Add advanced setting for disabling leading wildcards in kuery
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
lukasolson
added a commit
that referenced
this pull request
Mar 22, 2018
* First stab at refactoring typeahead * Don't double submit on enter * Add item templating * Introduce simple kuery language * Rename to kql and add modules * Update KQL syntax * Automatically insert matching pairs * Don't match quotes after alphanumeric chars * Get field and value suggestions * Remove accidental changes * Remove unnecessary test * Don't submit on enter * Fix typeahead * Suggest matching recent searches * Suggest operators * Suggest conjunctions * Use template, separate suggestions into separate modules * Whoops, add this module back * Add clarifying comment * Fix history log key * Don't update suggestions on every key press * Fix key handling * Update terminology to be clearer * Fix typo * Simplify building of nodes * Don't always hide on submit * Check items exists * Add icon directive which wraps EuiIcon. * kql design start * remove comment bits * Simplify select next/prev and reset selected on hide/backspace * Add test * Put persistedLog on scope so it can be tested * Fix typos * Build up AST for sublist by returning functions that take a field name * Remove single quoted strings and add double quote to special characters * Build nodes with arg nodes instead of args themselves * Add support for exact phrase search for quoted values * Update typeahead items when language changes * Finish that work I didn't do in the last commit * This commit makes Bargs very happy cuz it does a lot * Add wildcard field support to range query * Remove range support for wildcard values * Remove KQL as a separate language Updates kuery to use KQL's grammar. This will lead to a smoother transition for both us and Kuery users. We mainly added KQL as a separate language so that we could notify Kuery users that the syntax had changed. I realized we could do the same by trying to parse their query strings with the old grammar if the new grammar fails, and if the old grammar parses successfully we can display an error message with a link to the docs describing the syntax changes. Since Kuery now uses the more simple KQL syntax, I've also re-enabled the filter bar when Kuery is selected. * Fix typeahead behavior * Update conjunctions * Use scope apply * Suggest conjunctions after ranges * Support strings in wildcard node constructor and add tests for wildcard node * test updates * Removing unused serializeStyle and toKueryExpression, updating tests * Fix functional test * Fix typo * Show fields that match in any part of the name * Alter order of operators * Preserve focus after selecting by click * Ports tests for `fromKueryExpression` to `fromKqlExpression` * More KQL syntax tests * Suggest conjunctions after ranges * Fix suggestions inside parens * fromLiteralExpression tests * remove serializeStyle arguments which no longer exist in the function definition * tests for getFields * Case insensitive search for field names * update tests for is.js * add wildcard fieldname test for range.js * Fix removed div * Fix line spacing for autocomplete suggestions * Fix conjunction suggestions with escaped preceding literals * Escape special characters in fields and values * Don't suggest the value that's already selected * Update icons * Sort prefix first * Simplify cursor detection and suggest booleans * Use quotes for suggested values * get rid of references to KQL * Don't show errors from parsing * That didn't even exist * Use config to determine if values are suggested * Update suggestions on home/end * remove hack * Update reference to kql * Suggestions for quoted values * Clean up grammar * Better support for cursor inside spaces * Create grunt task to generate parsers from peg files * Simplify wildcard handling * Don't filter out the exact fields/values * Update parsing modules * Fix peg task * Make operator syntax more visible * Update OR verbiage * Simplify and improve match pairs * Revert "Simplify wildcard handling" This reverts commit 915861b. * Support escaped backslashes inside quoted strings * Support escaped keywords * Remove lodash dependency cuz w33ble * Escape user input and fix conjunction description * Clear suggestions after submitting * Fix insertion of suggestion to account for selection * Remove unnecessary? * Remove extraneous file * Better name for method * Move functions out of event handler * Don't wrap result in promise * Don't show kuery suggestions for lucene * some cleanup and polish for kql autocomplete * Omit description completely for values * Don't suggest and/or for quoted strings that end in spaces * Submit recent search suggestions on select * Scroll selected suggestion into view * Better handling of key events and hiding typeahead * Update suggestions to work in other apps with multiple index patterns * Only update suggestions if not submitting * Hide suggestions on focus * Simplify wildcard (again) * Fix console error * Remove references to kql * Fix match pairs so that suggestions occur with cursor in correct place * Memoize value suggestions * Debounce model updates * Add tests for suggestion providers * Add setting and docs * Add custom error, helper for detecting leading wildcards, and check for leading wildcards in the Value rule of the grammar. * Better handling of suggestion clicks * Dedup suggestions * Sort keywords first * Fix value suggestions memoizing * Check if query exists * Reduce size of dialog and fix ranges * Create grunt task to generate parsers from peg files * Lazy load typeahead items * Fix wildcard tests * Fix value suggestion tests * Fix typeahead tests * Fix value suggestion memoize resolver * Leave comment * Add a ttl for the value suggestion resolver * Move grunt config to config/ * Bargs can suck it * Fix more tests that bargs broke (and one I did too) * Fix tests
|
6.x (6.3.0): b665a30 |
💚 Build Succeeded |
This was referenced Mar 29, 2018
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #14523.
Closes #12315.
Relies on #17069.
This PR adds autocomplete functionality to the simplified Kibana query language. It will autocomplete field names, operators, values, and conjunctions.
Value suggestions can be turned off using the same flag to turn off filter editor value suggestions (
filterEditor:suggestValues).