Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] Fix Security TS Errors #167581

Closed
wants to merge 2 commits into from

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Sep 28, 2023

Summary

Partially fixes #167373 for:

./x-pack/plugins/osquery/cypress/tsconfig.json

@Ikuni17 Ikuni17 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 28, 2023
@Ikuni17 Ikuni17 self-assigned this Sep 28, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 28, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 115 113 -2

Total ESLint disabled count

id before after diff
osquery 116 114 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Ikuni17

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Sep 29, 2023

Closing in favor of #167428

@Ikuni17 Ikuni17 closed this Sep 29, 2023
@Ikuni17 Ikuni17 deleted the backport/8.10/security-types branch September 29, 2023 12:54
delanni added a commit that referenced this pull request Oct 2, 2023
… to cypress (#167428) (#167614)

Backport of #167428

Replaces: #167581

Part of: #167373

---

The osquery-cypress package was referring to configurations from a
parent folder. This caused difficulties with having to exclude/include
the same files in the `tsconfig.json`s, leading to hard-to-resolve
typescript issues.

This PR moves the configs in, and cleans up redundancies and type
errors.

chore(osquery): move osquery/cypress configs to cypress folder, fix type
errors

---------

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
Co-authored-by: Brad White <Ikuni17@users.noreply.github.com>
Co-authored-by: Brad White <brad.white@elastic.co>
(cherry picked from commit e84742d)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants