[Osquery][Ops] Move Osquery/cypress configurations close to cypress #167428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
patrykkopycinski
approved these changes
Sep 27, 2023
…ni/kibana into clean-up-osquery-cypress-structure
watson
reviewed
Sep 28, 2023
…ni/kibana into clean-up-osquery-cypress-structure
💔 Build FailedFailed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Ikuni17
added a commit
to Ikuni17/kibana
that referenced
this pull request
Sep 28, 2023
delanni
added a commit
that referenced
this pull request
Sep 28, 2023
## Summary This is hopefully the last batch of typescript issues to be fixed, related to #166813. It's also re-enabling full typecheck, with this, we should be back in a clean, typechecked main branch. Blocked by #167428 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> Co-authored-by: Brad White <brad.white@elastic.co> Co-authored-by: Thomas Watson <watson@elastic.co> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Sep 29, 2023
…c#167392) ## Summary This is hopefully the last batch of typescript issues to be fixed, related to elastic#166813. It's also re-enabling full typecheck, with this, we should be back in a clean, typechecked main branch. Blocked by elastic#167428 --------- Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> Co-authored-by: Brad White <brad.white@elastic.co> Co-authored-by: Thomas Watson <watson@elastic.co> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8a29a5e) # Conflicts: # .buildkite/pipelines/pull_request/base.yml # .buildkite/scripts/steps/check_types_commits.sh
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Sep 29, 2023
…lastic#167428) The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the `tsconfig.json`s, leading to hard-to-resolve typescript issues. This PR moves the configs in, and cleans up redundancies and type errors. chore(osquery): move osquery/cypress configs to cypress folder, fix type errors --------- Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> Co-authored-by: Brad White <brad.white@elastic.co> (cherry picked from commit e84742d)
delanni
added a commit
that referenced
this pull request
Oct 2, 2023
… to cypress (#167428) (#167614) Backport of #167428 Replaces: #167581 Part of: #167373 --- The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the `tsconfig.json`s, leading to hard-to-resolve typescript issues. This PR moves the configs in, and cleans up redundancies and type errors. chore(osquery): move osquery/cypress configs to cypress folder, fix type errors --------- Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Brad White <Ikuni17@users.noreply.github.com> Co-authored-by: Brad White <brad.white@elastic.co> (cherry picked from commit e84742d) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the
tsconfig.jsons, leading to hard-to-resolve typescript issues.This PR moves the configs in, and cleans up redundancies and type errors.
chore(osquery): move osquery/cypress configs to cypress folder, fix type errors