Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search] Rename OrFilter to CombinedFilter #142761

Merged

Conversation

nlatipov
Copy link
Contributor

@nlatipov nlatipov commented Oct 5, 2022

Summary

One of the goals that we want to achieve during the execution of the #127247 is to enable the user to create filters of any complexity with the establishment of AND/OR relationships between them.

To achieve this goal, it was initially decided to add an OrFilter to the application to group filters with an OR relation. And for the AND relation, it was decided to use the nested array in OrFilter

interface OrFilter { 
  meta: {
    type: ‘OR’,
    params: {
      filters: Filter[] 
    }
  }
}

After the last discussion, was decided to rename OrFilter to CombinedFilter as it better reflects the behavior of this type of object.

interface CombinedFilter { 
  meta: {
    type: ‘combined’,
    params: {
      filters: Filter[] 
    }
  }
}

@nlatipov nlatipov self-assigned this Oct 5, 2022
@nlatipov nlatipov added Feature:Filters release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks v8.6.0 labels Oct 5, 2022
@nlatipov
Copy link
Contributor Author

nlatipov commented Oct 5, 2022

@elasticmachine merge upstream

@nlatipov nlatipov requested a review from alexwizp October 6, 2022 05:34
@nlatipov
Copy link
Contributor Author

nlatipov commented Oct 7, 2022

@elasticmachine merge upstream

@nlatipov nlatipov marked this pull request as ready for review October 7, 2022 08:46
@nlatipov nlatipov requested a review from a team as a code owner October 7, 2022 08:46
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming makes sense to me! Thanks, @nlatipov . @lukasolson please have a look

@nlatipov nlatipov added the WIP Work in progress label Oct 7, 2022
@nlatipov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 766.5KB 766.5KB +18.0B
apm 3.1MB 3.1MB +12.0B
canvas 1.0MB 1.0MB +12.0B
cloudSecurityPosture 203.4KB 203.4KB +18.0B
controls 459.1KB 459.2KB +18.0B
dashboard 419.5KB 419.6KB +36.0B
dataViewManagement 149.2KB 149.2KB +18.0B
dataVisualizer 571.2KB 571.3KB +18.0B
discover 479.0KB 479.1KB +36.0B
discoverEnhanced 44.6KB 44.6KB +36.0B
fleet 912.5KB 912.5KB +12.0B
graph 451.5KB 451.5KB +12.0B
infra 1.0MB 1.0MB +18.0B
inputControlVis 78.3KB 78.3KB +12.0B
lens 1.3MB 1.3MB +36.0B
lists 152.7KB 152.7KB +12.0B
ml 3.4MB 3.4MB +18.0B
monitoring 479.8KB 479.8KB +12.0B
observability 528.9KB 528.9KB +18.0B
osquery 1.0MB 1.0MB +12.0B
stackAlerts 101.1KB 101.1KB +12.0B
synthetics 1.0MB 1.0MB +12.0B
threatIntelligence 116.0KB 116.0KB +18.0B
transform 388.9KB 388.9KB +18.0B
triggersActionsUi 671.8KB 671.8KB +12.0B
unifiedFieldList 55.0KB 55.0KB +18.0B
unifiedSearch 261.6KB 261.6KB +36.0B
upgradeAssistant 179.8KB 179.9KB +12.0B
visTypeTimelion 109.2KB 109.2KB +18.0B
visTypeVega 1.7MB 1.7MB +18.0B
visualizations 240.2KB 240.2KB +12.0B
total +570.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 42.8KB 42.8KB +12.0B
data 437.0KB 437.1KB +18.0B
maps 82.1KB 82.1KB +12.0B
securitySolution 265.1KB 265.1KB +18.0B
timelines 269.3KB 269.3KB +18.0B
total +78.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nlatipov

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nlatipov nlatipov merged commit 0518a74 into elastic:main Oct 10, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
* feat: OrFilter -> CombinedFilter

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* feat: updated filter's type OR -> combined

* fix: jest test
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
* feat: OrFilter -> CombinedFilter

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* feat: updated filter's type OR -> combined

* fix: jest test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Filters Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes v8.6.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants