-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified Search] Rename OrFilter to CombinedFilter #142761
[Unified Search] Rename OrFilter to CombinedFilter #142761
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming makes sense to me! Thanks, @nlatipov . @lukasolson please have a look
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nlatipov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* feat: OrFilter -> CombinedFilter * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * feat: updated filter's type OR -> combined * fix: jest test
* feat: OrFilter -> CombinedFilter * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * feat: updated filter's type OR -> combined * fix: jest test
Summary
One of the goals that we want to achieve during the execution of the #127247 is to enable the user to create filters of any complexity with the establishment of AND/OR relationships between them.
To achieve this goal, it was initially decided to add an OrFilter to the application to group filters with an OR relation. And for the AND relation, it was decided to use the nested array in OrFilter
After the last discussion, was decided to rename OrFilter to CombinedFilter as it better reflects the behavior of this type of object.