Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search] Complex filter capabilities - Support ORs #127247

Closed
3 tasks done
stratoula opened this issue Mar 9, 2022 · 10 comments
Closed
3 tasks done

[Unified search] Complex filter capabilities - Support ORs #127247

stratoula opened this issue Mar 9, 2022 · 10 comments
Assignees
Labels
Feature:Unified search Unified search related tasks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure WIP Work in progress

Comments

@stratoula
Copy link
Contributor

stratoula commented Mar 9, 2022

Describe the feature:
We want to give the users the ability to create more complex filter expressions by supporting ORs.

Currently, the users are able to create one filter at the time and all the filters applied are related with AND. (filter1: A AND filter2: B etc). We would like to enhance our query builder in order to give the users the ability to create N-depth complexity filters related with AND/ORs.

The UI will look like this:
image

Tasks:

Step 1 (preparation):

  • Create a filter form component which will work with nested OR/AND filters
    Notes:
    - nesting is limited by the passed parameter;
    - user should be able to add/modify multiple filters with complex relationships;
    - new component should support drag and drop experience;
    - new component should be developed with the focus of what will become shared.

Step 2 (integration):

  • Moves the filter form and DSL query into a robust modal
  • The filters will be presented to the UI as enhanced filter badges

image

Notes

  • In order to create smaller PRS and being able to work on this in parallel, we should create a feature branch.
  • This task needs user testing as it introduces many changes
@stratoula stratoula added Team:AppServicesSv Feature:Unified search Unified search related tasks labels Mar 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 14, 2022
@exalate-issue-sync exalate-issue-sync bot added the loe:medium Medium Level of Effort label Jul 21, 2022
@nlatipov nlatipov added the WIP Work in progress label Jul 27, 2022
@alexwizp alexwizp self-assigned this Jul 29, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed loe:medium Medium Level of Effort impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 26, 2022
@nlatipov nlatipov reopened this Oct 10, 2022
@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:AppServicesSv labels Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added loe:weeks and removed loe:medium Medium Level of Effort labels Dec 21, 2022
@cyber-petushator
Copy link

Hello! This seems to be completed, but when we can see it in Kibana release?

@stratoula
Copy link
Contributor Author

stratoula commented Apr 3, 2023

It is available in 8.7!

@cyber-petushator
Copy link

cyber-petushator commented Apr 3, 2023

It is available in 8.7!

Thanks will try it. Din't know it's out. Very recently! :)

@cyber-petushator
Copy link

cyber-petushator commented Apr 4, 2023

It is available in 8.7!

Yes. It is up and running in 8.7. Thank you.
Unfortunately it does not work as i hope...
This feature give user filter builder gui which allow to build SINGLE complex filter (with AND/OR relationships within this complex filter). This filter in fact turns into simple KQL query (which is frankly faster to write than select from gui).

What this feature lacks - it is ability to quickly add new filter from some Discover / Dashboard / Map by selected field value with OR relationship to already existing filters collection.

That, in my humble opinion, makes this feature quite useless :(

At least for my user cases. (Didn't meant to disappoint devs).

@stratoula
Copy link
Contributor Author

@cyber-petushator something like that you mean? #148372

@cyber-petushator
Copy link

@cyber-petushator something like that you mean? #148372

Thanks for reply!
Mentioned feature are closer to what iam looking for but not exactly.

If you don't mind i'll try to give live example.
Let's take a map (Kibana-maps) which tracks active entities and may present historical data for chosen entities.
Let's pretend we tracking network connection (with geoip). By default operator have preconfigured filter "ActiveConnection:true" which correspond to appropriate field in doc.
Now some connection picks an interest, operator chose it with mouse click. Tooltip with info comes up.

Now what iam struggling to achieve is to give user ability to click on some field in tooltip which is uniquely describe entity (like IP address) to show all historical data about this entity.

That in filter language should mean:
Add to existing filter new filter with OR. Like:
ActiveConnection:true OR IP:1.2.3.4
Thing is it should be two separate filter. One should be preconfigured (and basically always on) and second one should be addable via click on some property but with OR (not AND is it now).

@stratoula
Copy link
Contributor Author

I see so you would like 2 filter pills in this case but connected with OR not AND. It is not possible atm unfortunately, if you want to create an OR relationship it should be on the same filter pill.

One ehnancement could be to give the option to disable temporarily filter rows, e.g. I could disable the second one
image

Wdyt?

@cyber-petushator
Copy link

I see so you would like 2 filter pills in this case but connected with OR not AND. It is not possible atm unfortunately, if you want to create an OR relationship it should be on the same filter pill.

One ehnancement could be to give the option to disable temporarily filter rows, e.g. I could disable the second one image

Wdyt?

Thanks for understanding. Iam glad to reach the understanding that is not possible ( that means that i didn't miss some knowledge how to do it).

About enhancement you mention - i don't see how it helps (in my case). Thank you nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Unified search Unified search related tasks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure WIP Work in progress
Projects
None yet
Development

No branches or pull requests

5 participants