Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Hide filter bar when no filters so it doesn't show up in embed mode #14075

Conversation

stacey-gammon
Copy link
Contributor

Something else seems to hide it in non-embed mode, but this code is in
6.0 and onward, and does the trick.

Before:
screen shot 2017-09-20 at 8 49 17 am

After:
screen shot 2017-09-20 at 8 48 15 am

Fixes #13894 for 5.6.2

Something else seems to hide it in non-embed mode, but this code is in
6.0 and onward, and does the trick.
@nreese
Copy link
Contributor

nreese commented Sep 20, 2017

This change hides the Apply these filters GUI from displaying when filtering a multi-dimensional visualization in embedded mode.

In kibana, when a user clicks on a bar, the following is displayed
screen shot 2017-09-20 at 8 26 19 am

When a user clicks on a bar in embedded mode - nothing happens and the above GUI is not displayed.

@stacey-gammon
Copy link
Contributor Author

Turns out we want the filter bar to always show up as it helps out accessibility, so going to abandon this (see #14076 for background). Has the added benefit of not backporting a PR that has errors anyway. Thanks for the detailed review @nreese, sorry for the waste of time.

@stacey-gammon stacey-gammon deleted the 5.6/fix/hide-filter-bar-when-no-filters branch September 21, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants