Inconsistent behavior with empty filter bar on dashboard

[stacey-gammon]

On master, it looks like jumping into edit mode causes an empty filter bar to appear, and then it stays even after hitting cancel.

cc @elastic/kibana-discovery - how do you think it should work? Seems similar to our conversations regarding #13894. I thought our current logic is, if there are no filters, don't show it? I have a fix out for that issue above, for 5.6 - #14075. But I want to make sure I'm making the right assumptions on how it should work.

[Bargs]

We should always show the filter bar unless the dashboard has no panels (I think we should even show it then, but that's a separate issue). Otherwise the "Add a filter" button is not accessible unless you already have a filter.

[stacey-gammon]

Ah, interesting. How do you feel about 5.6? Should it be hidden there, since it was hidden before, and only introduce the change for accessibility stuff in 6.0 and onward? The behavior in 5.6 is inconsistent anyway. We should either fix it so it always shows up, or hide it like in prior versions.

[Bargs]

I'm not sure why it was hidden in 6.0. It looks like #12265 added that condition. Does it have something to do with full screen mode?

I haven't checked it out yet, but I suspect the filter bar was never specifically hidden in embed mode. Prior to the addition of the filter editors you wouldn't see anything if there were no filters. But prior to 5.5, if you clicked on a visualization in an embedded dashboard, I'm betting the filter bar would still show up, no? If that's the case (I can confirm later if no one knows of the top of their head), then we probably shouldn't hide the "Add a filter" button even when it's embedded.

[stacey-gammon]

But prior to 5.5, if you clicked on a visualization in an embedded dashboard, I'm betting the filter bar would still show up, no?

Yes, but it didn't show up when there were no filters. There are users who specifically do not like that it shows up when there are no filters. Probably a UX thing?

We want to eventually add a bunch of embeddable options that will fix the UX thing (people can hide the filter bar, whether or not there are filters applied). I'm on board if you think it should always show up, even when there are no filters, for accessibility reasons. I just want to make sure our message is consistent. I will update that ticket as will not fix and abandon the PR, since it's our intention to either always show the filter bar, even if it's empty, or never show the filter bar, even if it's filled (depending on settings which don't exist yet - so for now it should always be the former).

[Bargs]

There are users who specifically do not like that it shows up when there are no filters.

Out of curiosity, why do they want that? If users can create filters (by clicking on visualizations) but cannot see them, won't that be super confusing? Or would we also disable the ability to create/modify filters if the filter bar is hidden?

[stacey-gammon]

The issue is that panelIndexPatternMapping in dashboardState is not saved on appState which means changes aren't propagated to the scope in dashboard.js. So the index patterns map is only updated once something else triggers the updateState call in dashboard.js, which updates the scope object, which then updates the filter bar.

The fix for this will change once #14199 is checked in. In that world, I can just put the indexPatterns on the embeddable object and store it in redux. So unless we feel strongly this should go in 6.0 or 5.6, I'm going to wait till that redux PR is in and then fix it for 6.1.

[bhavyarm]

If I pin a filter and open dashboard (an existing dashboard or a new dashboard) it shows up. But if I open dashboard in a new window - the pinned filter doesn't show up.

[nreese]

closed by #16235