Only use day, month, year provided by datepicker #11773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
approved these changes
May 15, 2017
lukasolson
requested changes
May 15, 2017
|
@lukasolson test added |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
May 17, 2017
* Only use day, month, year provided by datepicker instead of moment in time
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
May 17, 2017
* Only use day, month, year provided by datepicker instead of moment in time
Bargs
added a commit
that referenced
this pull request
May 18, 2017
Bargs
added a commit
that referenced
this pull request
May 18, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* Only use day, month, year provided by datepicker instead of moment in time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5370
The datepicker directive uses native Javascript Dates, ignoring moment's default timezone. This causes the datepicker and the text input above it to get out of sync if the user changed the
dateFormat:tzconfig in advanced settings. The text input will show the date in the user selected timezone, the datepicker will show the date in the local browser timezone. Since we really just want a day, month, year from the datepicker instead of a moment in time, we grab those individual values from the native date.