Prevent undefined from and to timepicker dates. #20355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
bug
|
How are you deleting the values and pressing go? The go button should be disabled since the dates are not valid
|
|
@nreese I'm not pressing go, I'm just deleting the value like you have it. Even without pressing go, it seems to update the |
|
Looks like this was introduced recently by https://github.com/elastic/kibana/pull/11773/files#diff-ede1c90ee2df4a30c094c7a838bc51abR82 |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
cjcenizal
added a commit
that referenced
this pull request
Jun 29, 2018
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you delete the "to" or "from" dates in the timepicker, you get errors:
This PR prevents this from happening.