Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate search:includeFrozen parameter #114578

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

lukasolson
Copy link
Member

Summary

Deprecates the search:includeFrozen advanced setting. This setting corresponds with the Elasticsearch ignore_throttled search parameter which has also been deprecated.

Since Elasticsearch will still support searching frozen indices (but will not allow freezing unfrozen indices) in 8.x, this parameter will need to stick around until 9.0.

image

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

Release note

The advanced setting search:includeFrozen has been deprecated and will be removed in 9.0.

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppServicesSv auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 11, 2021
@lukasolson lukasolson requested a review from a team as a code owner October 11, 2021 23:08
@lukasolson lukasolson self-assigned this Oct 11, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit a070aaf into elastic:master Oct 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 13, 2021
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Oct 13, 2021
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Search Querying infrastructure in Kibana release_note:deprecation v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants