Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[os/kibana.yml] Use new logger #111192

Merged
merged 4 commits into from
Sep 8, 2021
Merged

[os/kibana.yml] Use new logger #111192

merged 4 commits into from
Sep 8, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Sep 3, 2021

This updates deb and rpm packages to use the new logger. The
configuration written to kibana.yml:

logging:
  appenders:
    file:
      type: file
      fileName: /var/log/kibana/kibana.log
      layout:
        type: pattern
  root:
    appenders:
      - default
      - file

@jbudz
[os/kibana.yml] Use new logger
ed285e7 
This updates deb and rpm packages to use the new logger.  The
configuration written to kibana.yml:

```
logging:
  appenders:
    file:
      type: file
      fileName: /var/log/kibana/kibana.log
      layout:
        type: pattern
  root:
    appenders:
      - default
      - file
```
@jbudz
update package test configuration
1afb919
@jbudz jbudz added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v8.0.0 backport:skip This commit does not require backporting labels Sep 3, 2021
@jbudz jbudz requested a review from a team as a code owner September 3, 2021 17:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Sep 3, 2021
@tylersmalley tylersmalley requested a review from a team September 3, 2021 18:08
@jbudz
Copy link
Member Author

jbudz commented Sep 7, 2021

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

I am seeing that we were previously logging in JSON. We should update this to use the JSON appender.

@jbudz
Copy link
Member Author

jbudz commented Sep 7, 2021

Switched to the JSON layout in b6c87bf

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pgayvallet
pgayvallet approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging config LGTM

@jbudz jbudz merged commit f2c00fd into elastic:master Sep 8, 2021
@jbudz jbudz deleted the os/legacy-logging branch September 8, 2021 19:43
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
@jbudz @kibanamachine @chrisronline
[os/kibana.yml] Use new logger (elastic#111192)
ebb81d8 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz jbudz mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @tylersmalley @kibanamachine @pgayvallet