Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deb/rpm] Deprecation warnings caused by legacy logger #109159

Closed
jbudz opened this issue Aug 18, 2021 · 3 comments
Closed

[deb/rpm] Deprecation warnings caused by legacy logger #109159

jbudz opened this issue Aug 18, 2021 · 3 comments
Assignees
Labels
Team:Operations Team label for Operations Team

Comments

@jbudz
Copy link
Member

jbudz commented Aug 18, 2021

OS Packages make use of the legacy logger by setting logging.dest -

ExecStart=/usr/share/kibana/bin/kibana --logging.dest="/var/log/kibana/kibana.log" --pid.file="/run/kibana/kibana.pid"

This setting was deprecated in 7.13.0 - #94238 and causes console warnings now. Using the new logging configuration changes the logging format and [1]still logs to stdout (for now).

[1]https://www.elastic.co/guide/en/kibana/current/logging-settings.html#logging-settings

When you switch to the new logging configuration, you will start seeing duplicate log entries in both formats. These will be removed when the default appender is no longer required.

logging:
  appenders:
    file:
      type: file
      fileName: kibana.log
      layout:
        type: pattern
  root:
    appenders: [default, file]

We don't want to break the logging format in 7.x, so it looks like the way forward is to continue using the deprecated logger in 7.x. @elastic/kibana-core does this make sense? Looking for recommendations on how we want to approach this

@jbudz jbudz added the Team:Operations Team label for Operations Team label Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@lukeelmers
Copy link
Member

We don't want to break the logging format in 7.x, so it looks like the way forward is to continue using the deprecated logger in 7.x.

Using the new configuration will have no effect other than to introduce additional/duplicate logs to the same log file in the new format. It will not remove logs in the legacy format.

We decided we would not consider this a true breaking change as the legacy logs weren't removed -- although it is somewhat of a grey area (e.g. it would impact folks relying on grok patterns for parsing & ingesting kibana logs, but we decided this was an acceptable trade off)

@jbudz
Copy link
Member Author

jbudz commented Sep 13, 2021

Resolved with #111192 in 8.0. We don't want to break the log format in 7.x, so we'll have to leave the deprecation warning in.

@jbudz jbudz closed this as completed Sep 13, 2021
jbudz added a commit to jbudz/kibana that referenced this issue Dec 2, 2021
OS packages manage Kibana's logging configuration and will be updated
automatically to use the new logging configuration in 8.0. This skips
the critical deprecation error that will be logged by the upgrade
assistant for a package managed configuration.

Related to elastic#111263
Related to elastic#109159
jbudz added a commit that referenced this issue Dec 17, 2021
OS packages manage Kibana's logging configuration and will be updated
automatically to use the new logging configuration in 8.0. This skips
the critical deprecation error that will be logged by the upgrade
assistant for a package managed configuration.

Related to #111263
Related to #109159

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants