Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] use conventional error rate color for correlations #103500

Merged
merged 1 commit into from
Jun 30, 2021
Merged

[APM] use conventional error rate color for correlations #103500

merged 1 commit into from
Jun 30, 2021

Conversation

dgieselaar
Copy link
Member

Closes #97097.

Before:
image

After:
image

@dgieselaar dgieselaar requested a review from a team as a code owner June 28, 2021 15:13
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 28, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +29.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

smith
smith approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-204639919

@dgieselaar dgieselaar merged commit 8cf6e00 into elastic:master Jun 30, 2021
@dgieselaar dgieselaar deleted the correlation-error-color branch June 30, 2021 10:30
@dgieselaar dgieselaar mentioned this pull request Jun 30, 2021
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jun 30, 2021
@dgieselaar
[APM] use conventional error rate color for correlations (elastic#103500
0bcc73e 
)
dgieselaar added a commit that referenced this pull request Jun 30, 2021
@dgieselaar
[7.x] [APM] use conventional error rate color (#103500) (#103860)
f429949
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/ilm…
3797167 
…-policy-2

* 'master' of github.com:elastic/kibana:
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)

# Conflicts:
#	x-pack/plugins/reporting/server/lib/store/store.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
a29672d 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Correlations: The error rate correlations color is not consistent with other usage
6 participants
@dgieselaar @elasticmachine @kibanamachine @smith @sorenlouv @spalger