Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Migrating to kbn_archiver from es_archiver - for the Maps app #103028

Merged
merged 15 commits into from
Jun 30, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Jun 23, 2021

part of #102552

  • This exercise is to enable migrating from esArchiver to kbnArchiver which is a saved object export to handle this data - for all the maps app tests.
  • Also added the logic in index.js for deleting the missing references manually, using the API after successful import.

@rashmivkulkarni rashmivkulkarni added Team:QA Team label for QA Team [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation test_xpack_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 23, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Jun 23, 2021
@rashmivkulkarni rashmivkulkarni changed the title Migrating to kbn_archiver from es_archiver - for the Maps app [test] Migrating to kbn_archiver from es_archiver - for the Maps app Jun 23, 2021
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review only.

@bhavyarm
Copy link
Contributor

@rashmivkulkarni please add a couple of lines in desc to explain what your PR is doing. Thanks!

@bhavyarm bhavyarm added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 29, 2021
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change with the filename, after that LGTM.

 Please enter the commit message for your changes. Lines starting
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for migrating the maps tests to kbn_archiver.
code review

x-pack/test/functional/apps/maps/index.js Show resolved Hide resolved
@rashmivkulkarni rashmivkulkarni merged commit 4cb979b into elastic:master Jun 30, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 103028

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
rashmivkulkarni added a commit that referenced this pull request Jun 30, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 103028 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 2, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 103028 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 103028 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 103028 or prevent reminders by adding the backport:skip label.

@bhavyarm bhavyarm added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 7, 2021
@bhavyarm
Copy link
Contributor

bhavyarm commented Jul 7, 2021

@rashmivkulkarni will have to do the backport manually because .kibana* from 8.0.0 for kbnArchiver doesn't work for 7.x. Removing the labels. Thanks!

@spalger spalger removed the v7.14.0 label Jul 7, 2021
@spalger
Copy link
Contributor

spalger commented Jul 7, 2021

@bhavyarm I removed the 7.14 label too, if you're planning to backport this to 7.14 please make sure to add the 7.15 and 7.14 labels back. Thank you!

rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Jul 15, 2021
…lastic#103028)

* converting Maps es_archiver to kbn_archiver

* delete the esArchiver .kibana reference directory

* fix the path of the json file

* use the delete API to delete the missing references populated in the data.json

* fix the path

* kbn_archiver_maps.json

* added the missing ref

* restoring it to use esArchiver

* replace esArchiver to use kbnArchiver

* moved the data.json directly under kbnArchiver

 Please enter the commit message for your changes. Lines starting

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/es_archives/maps/kibana/mappings.json
rashmivkulkarni added a commit that referenced this pull request Jul 15, 2021
…103028) (#105838)

* converting Maps es_archiver to kbn_archiver

* delete the esArchiver .kibana reference directory

* fix the path of the json file

* use the delete API to delete the missing references populated in the data.json

* fix the path

* kbn_archiver_maps.json

* added the missing ref

* restoring it to use esArchiver

* replace esArchiver to use kbnArchiver

* moved the data.json directly under kbnArchiver

 Please enter the commit message for your changes. Lines starting

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/es_archives/maps/kibana/mappings.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_xpack_functional v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants