[Dashboard]: Fixes disabled viz filter is applied #101859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:Filters
release_note:fix
v7.14.0
v8.0.0
Feature:Dashboard
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kibanamachine
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
stratoula
added
impact:medium
stratoula
changed the title
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
streamich
approved these changes
Jun 14, 2021
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jun 14, 2021
* Fixes filter is applied even if is disabled on a dashboard * Fix 18n problem Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 14, 2021
* master: [Security solution][Endpoint] Removes zip compression when creating artifacts (elastic#101379) [Dashboard]: Fixes disabled viz filter is applied (elastic#101859) [Discover] Deangularization of search embeddable (elastic#100552)
stratoula
added a commit
that referenced
this pull request
Jun 14, 2021
* Fixes filter is applied even if is disabled on a dashboard * Fix 18n problem Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jun 15, 2021
* Fixes filter is applied even if is disabled on a dashboard * Fix 18n problem Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jun 18, 2021
* Fixes filter is applied even if is disabled on a dashboard * Fix 18n problem Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Jun 18, 2021
* Fixes filter is applied even if is disabled on a dashboard * Fix 18n problem Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #101720
We found out that if a visualization has a disabled filter and is embedded on a dashboard, the filter is applied.
For example here, when I am on the viz editor, the pie chart is rendered correctly but when I embedded on a dashboard it appears with no results.
The problem was on the kibanaFilter expression. The disabled prop is always set to false. I changed it to be dynamically set.
Checklist