Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Disabled filter is applied when a viz is embedded #101720

Closed
stratoula opened this issue Jun 9, 2021 · 4 comments · Fixed by #101859
Closed

[Dashboard] Disabled filter is applied when a viz is embedded #101720

stratoula opened this issue Jun 9, 2021 · 4 comments · Fixed by #101859
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Jun 9, 2021

Kibana version:
master

Describe the bug:
I create a visualization with a disabled and an enabled filter. The visualization is depicted correctly on the editor. When I add this to a dashboard it is rendered with no data.

Steps to reproduce:

  1. Create a pie chart and add one disabled and one enabled filter
  2. add this viz to a dashboard
  3. The viz appears with no data

Expected behavior:
It should render correctly

Screenshots (if relevant):
image
image

Note:

  • The problem appears only if I have a combination of disabled and enabled filters.
  • The problem happens for by value and by reference visualizations
@stratoula stratoula added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features labels Jun 9, 2021
@kibanamachine kibanamachine added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 9, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 9, 2021
@stratoula stratoula removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jun 9, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 9, 2021
@stratoula stratoula added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jun 9, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 9, 2021
@stratoula stratoula added Team:AppServices Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ThomThomson
Copy link
Contributor

I've been testing this out. It appears that disabled filters work correctly on Lens, but disabled filters are actually applied in Visualize. You don't need conflicting filters like the example above, you can see the same behaviour by disabling a filter which would remove all data if it were enabled.

Screen Shot 2021-06-09 at 10 13 11 AM

Screen Shot 2021-06-09 at 10 13 21 AM

This is most likely a problem with the implementation of visualize, and seems to be independent of 'by value' or 'by reference'.

I will look into the code to see if I can find any implementation differences between Visualize and Lens in this way.

@stratoula stratoula changed the title [Dashboard] Renders no data if a viz has a disabled and an enabled filter [Dashboard] Disabled filter is applied when a viz is embedded Jun 10, 2021
@stratoula stratoula self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants