Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[so-migrations] Integration test fixes: Use default distribution for cleanup fixture creation #101698

Merged
merged 1 commit into from
Jun 10, 2021
Merged

[so-migrations] Integration test fixes: Use default distribution for cleanup fixture creation #101698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...server/saved_objects/migrationsv2/integration_tests/archives/7.13.0_with_corrupted_so.zip
View file
Open in desktop
Binary file not shown.
5 changes: 2 additions & 3 deletions src/core/server/saved_objects/migrationsv2/integration_tests/cleanup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ function createRoot() {
);
}

// FAILING: https://github.com/elastic/kibana/issues/98352
describe.skip('migration v2', () => {
describe('migration v2', () => {
let esServer: kbnTestServer.TestElasticsearchUtils;
let root: Root;

Expand All @@ -78,7 +77,7 @@ describe.skip('migration v2', () => {
adjustTimeout: (t: number) => jest.setTimeout(t),
settings: {
es: {
license: 'trial',
license: 'basic',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, we can remove it since basic is the default value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to know. There's no harm it keeping it though, as a reminder to use the default distro.

// original SO:
// {
// _index: '.kibana_7.13.0_001',
Expand Down