[so-migrations] Integration test fixes: Use default distribution for cleanup fixture creation #101698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
Team:Core
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
reviewed
Jun 10, 2021
| @@ -78,7 +77,7 @@ describe.skip('migration v2', () => { | |||
| adjustTimeout: (t: number) => jest.setTimeout(t), | |||
| settings: { | |||
| es: { | |||
| license: 'trial', | |||
| license: 'basic', | |||
There was a problem hiding this comment.
btw, we can remove it since basic is the default value
There was a problem hiding this comment.
That's good to know. There's no harm it keeping it though, as a reminder to use the default distro.
mshustov
approved these changes
Jun 10, 2021
TinaHeiligers
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 10, 2021
…cleanup fixture creation (elastic#101698)
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #98352
Use the default distribution for integration test fixtures creation.
Checklist
For maintainers