[Security Solution][Timeline] Fix breadcrumbs path reopens timeline when timeline modal is open #101568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
@elasticmachine merge upstream |
machadoum
changed the title
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
cnasikas
reviewed
Jun 22, 2021
x-pack/plugins/security_solution/public/common/components/navigation/breadcrumbs/index.ts
Outdated
Show resolved
Hide resolved
cnasikas
approved these changes
Jun 22, 2021
machadoum
force-pushed
the
siem-timeline-issue-100322
branch
from
0ba7775
to
a3456db
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
machadoum
added a commit
that referenced
this pull request
Jun 24, 2021
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 15, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 15, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 16, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 16, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 16, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 16, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 20, 2021
…open (elastic#101568)" This reverts commit 5b0d325.
machadoum
added a commit
that referenced
this pull request
Sep 20, 2021
… applied (#111369) * Fix useUrlStateHooks endless redirect loop Whenever the redux store changes, useUrlStateHooks updates the URL to sync with the store content. But when we navigate to a different page, it is also called to build the new page query string. If we update the store and navigate to a URL in a small time window, it could create an endless loop of useUrlStateHooks calls because the current URL doesn't get passed down to the router props. So when calling history.replace to update the query string, it would redirect to the previous page. * Revert "Fix Kibana page crash on redirect navigation when timeline is open (#104288)" This reverts commit 1ae7afd. * Revert "Fix breadcrumbs path reopens timeline when timeline modal is open (#101568)" This reverts commit 5b0d325. * Fix properly "breadcrumbs path reopens timeline when timeline modal is open" Since the redirect loop is fixed we can easily dispatch an action to close the timeline. * Fix eslint issue
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2021
… applied (elastic#111369) * Fix useUrlStateHooks endless redirect loop Whenever the redux store changes, useUrlStateHooks updates the URL to sync with the store content. But when we navigate to a different page, it is also called to build the new page query string. If we update the store and navigate to a URL in a small time window, it could create an endless loop of useUrlStateHooks calls because the current URL doesn't get passed down to the router props. So when calling history.replace to update the query string, it would redirect to the previous page. * Revert "Fix Kibana page crash on redirect navigation when timeline is open (elastic#104288)" This reverts commit 1ae7afd. * Revert "Fix breadcrumbs path reopens timeline when timeline modal is open (elastic#101568)" This reverts commit 5b0d325. * Fix properly "breadcrumbs path reopens timeline when timeline modal is open" Since the redirect loop is fixed we can easily dispatch an action to close the timeline. * Fix eslint issue
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2021
… applied (#111369) (#112546) * Fix useUrlStateHooks endless redirect loop Whenever the redux store changes, useUrlStateHooks updates the URL to sync with the store content. But when we navigate to a different page, it is also called to build the new page query string. If we update the store and navigate to a URL in a small time window, it could create an endless loop of useUrlStateHooks calls because the current URL doesn't get passed down to the router props. So when calling history.replace to update the query string, it would redirect to the previous page. * Revert "Fix Kibana page crash on redirect navigation when timeline is open (#104288)" This reverts commit 1ae7afd. * Revert "Fix breadcrumbs path reopens timeline when timeline modal is open (#101568)" This reverts commit 5b0d325. * Fix properly "breadcrumbs path reopens timeline when timeline modal is open" Since the redirect loop is fixed we can easily dispatch an action to close the timeline. * Fix eslint issue Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Sep 21, 2021
… applied (elastic#111369) * Fix useUrlStateHooks endless redirect loop Whenever the redux store changes, useUrlStateHooks updates the URL to sync with the store content. But when we navigate to a different page, it is also called to build the new page query string. If we update the store and navigate to a URL in a small time window, it could create an endless loop of useUrlStateHooks calls because the current URL doesn't get passed down to the router props. So when calling history.replace to update the query string, it would redirect to the previous page. * Revert "Fix Kibana page crash on redirect navigation when timeline is open (elastic#104288)" This reverts commit 1ae7afd. * Revert "Fix breadcrumbs path reopens timeline when timeline modal is open (elastic#101568)" This reverts commit 5b0d325. * Fix properly "breadcrumbs path reopens timeline when timeline modal is open" Since the redirect loop is fixed we can easily dispatch an action to close the timeline. * Fix eslint issue # Conflicts: # x-pack/plugins/security_solution/public/common/components/navigation/breadcrumbs/index.test.ts
machadoum
added a commit
that referenced
this pull request
Sep 21, 2021
… applied (#111369) (#112637) * Fix useUrlStateHooks endless redirect loop Whenever the redux store changes, useUrlStateHooks updates the URL to sync with the store content. But when we navigate to a different page, it is also called to build the new page query string. If we update the store and navigate to a URL in a small time window, it could create an endless loop of useUrlStateHooks calls because the current URL doesn't get passed down to the router props. So when calling history.replace to update the query string, it would redirect to the previous page. * Revert "Fix Kibana page crash on redirect navigation when timeline is open (#104288)" This reverts commit 1ae7afd. * Revert "Fix breadcrumbs path reopens timeline when timeline modal is open (#101568)" This reverts commit 5b0d325. * Fix properly "breadcrumbs path reopens timeline when timeline modal is open" Since the redirect loop is fixed we can easily dispatch an action to close the timeline. * Fix eslint issue # Conflicts: # x-pack/plugins/security_solution/public/common/components/navigation/breadcrumbs/index.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #100322
Summary
Breadcrumbs links are in sync with the URL query string to preserve the APP state (filters and timeline bar) when the user navigates between different security pages. But because
timeline.isOpenis a query string, it is also preserved. To fix this issue, we have to explicitly settimeline.isOpentofalse.P.S.: This area of the code seems outdated. It would be nice to take some time and improve it.
Checklist