Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Dec-2019 & July-2020 deprecations #4065

Merged
merged 11 commits into from
Oct 16, 2020
Merged

Finish Dec-2019 & July-2020 deprecations #4065

merged 11 commits into from
Oct 16, 2020

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Sep 22, 2020 •
edited
Loading

🚧 Breaking Changes 🚧

Summary

Addresses the remaining Dec2019 & July2020 deprecations in #1469

July 2020

December 2019

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

1 similar comment
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

@chandlerprall chandlerprall marked this pull request as ready for review September 22, 2020 19:06
@cchaos
Copy link
Contributor

cchaos commented Sep 22, 2020

I'll start reviewing this one. But in general, lets hold off on actually merging any breaking changes as we're so close to feature freeze. Maybe set this as a draft for now until we're actually confident in merging?

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

@chandlerprall chandlerprall marked this pull request as draft September 22, 2020 20:59
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

@cchaos cchaos force-pushed the deprecation/1469-december-2019-july-2020 branch from 23768a0 to a87ed75 Compare October 13, 2020 13:54
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

@chandlerprall chandlerprall marked this pull request as ready for review October 13, 2020 17:39
cchaos
cchaos approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked through all the changes correlating to the list. 👍 LGTM! Just needs a changelog with all the breaks 😉

@chandlerprall
Copy link
Contributor Author

Will update changelog & merge alongside #4056

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4065/

@chandlerprall chandlerprall merged commit 826cc32 into elastic:master Oct 16, 2020
@chandlerprall chandlerprall deleted the deprecation/1469-december-2019-july-2020 branch October 16, 2020 18:19
@thompsongl thompsongl mentioned this pull request Oct 22, 2020
Merged
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
@kshitij86
Finish Dec-2019 & July-2020 deprecations (elastic#4065)
663c1f6 
* Removed logoAPM icon

* Removed euiHeaderNotification class

* Removed 'disabled' color from button components

* Removed deprecated 'withTitle' prop from EuiPopover

* Removed deprecated 'compressed' and 'displayOnly' props from EuiFormRow

* Removed deprecated prop usage from EuiFormRow's tests

* small cleanup

* Removing obsolete test

* linter

* changelog

Co-authored-by: cchaos <caroline.horn@elastic.co>
@akashgp09 akashgp09 mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @kibanamachine @cchaos