Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade EUI dependency #1066

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Mar 9, 2021

Summary

Making progress: #998

  • Upgraded EUI

EuiPopover no longer supports withTitle prop.
Removed EuiPopover's withTitle prop (#4065)

Checklist

- [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
- [ ] This was checked for cross-browser compatibility
- [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
- [ ] Unit tests were updated or added to match the most common scenarios

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@akashgp09 akashgp09 changed the title Chore: Upgraded EUI Build: Upgraded EUI Mar 9, 2021
@markov00 markov00 changed the title Build: Upgraded EUI build: upgrade EUI dependency Mar 10, 2021
@markov00
Copy link
Member

jenkins test this please

@markov00
Copy link
Member

Thanks for this PR @akashgp09
I've noticed a single failing visual regression test, the one that use the EUI color picker, it's just a small visual change and it's safe to just update the VRT.

legend-stories-test-ts-legend-stories-should-render-color-picker-on-mouse-click-1-diff

If you have storybook running locally (and docker installed on your machine) you can run the following command to update the VRTs:

yarn test:integration:local  legend_stories.test.ts --testNamePattern "picker" -u

and commit the updated image

if storybook is not running locally you can use

yarn test:integration  legend_stories.test.ts --testNamePattern "picker" -u

@markov00
Copy link
Member

jenkins test this please

@markov00 markov00 mentioned this pull request Mar 23, 2021
11 tasks
@markov00
Copy link
Member

jenkins test this please
I've tested locally and the VRT looks fine now, not sure what is going on on CI

@markov00 markov00 merged commit 7e2a5e1 into elastic:master Mar 23, 2021
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 26.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants