Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Option to disable device type extraction in user agent processor #71626

Merged
merged 3 commits into from
Apr 19, 2021
Merged

[DOCS] Option to disable device type extraction in user agent processor #71626

merged 3 commits into from
Apr 19, 2021

Conversation

danhermann
Copy link
Contributor

@danhermann danhermann commented Apr 13, 2021 •
edited
Loading

@danhermann danhermann added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.13.0 labels Apr 13, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Apr 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@danhermann
Copy link
Contributor Author

@elasticmachine update branch

jrodewig
jrodewig approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this review @danhermann. I was away on vacation for a bit.

LGTM with a couple of minor changes.

docs/reference/ingest/processors/user-agent.asciidoc Outdated Show resolved Hide resolved
@danhermann danhermann mentioned this pull request Apr 19, 2021
Merged
@alisonelizabeth alisonelizabeth mentioned this pull request Apr 19, 2021
Closed
@danhermann @jrodewig
Update docs/reference/ingest/processors/user-agent.asciidoc
5369b8e 
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@danhermann
Copy link
Contributor Author

Thanks for your patience on this review @danhermann. I was away on vacation for a bit.

Thanks, @jrodewig. I saw that you were on vacation and I hope it was a good one for you!

@danhermann danhermann merged commit ac4e6d4 into elastic:master Apr 19, 2021
@danhermann danhermann deleted the docs_for_71408_ua_device_type branch April 19, 2021 15:55
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Jun 2, 2021
@danhermann
[DOCS] Option to disable device type extraction in user agent process…
40786b2 
…or (elastic#71626)
@danhermann danhermann mentioned this pull request Jun 2, 2021
Merged
danhermann added a commit that referenced this pull request Jun 2, 2021
@danhermann
[DOCS] Option to disable device type extraction in user agent process…
321075c 
…or (#71626) (#73697)
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Sep 14, 2021
@danhermann
[DOCS] Option to disable device type extraction in user agent process…
79fbf30 
…or (elastic#71626)
@danhermann danhermann mentioned this pull request Sep 14, 2021
Merged
danhermann added a commit that referenced this pull request Sep 14, 2021
@danhermann
[DOCS] Option to disable device type extraction in user agent process…
824f1d4 
…or (#71626) (#77705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
backport pending :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danhermann @elasticmachine @jrodewig @jakelandis