Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Node Pipelines] Add extract_device_type option to user agent processor #97466

Closed
alisonelizabeth opened this issue Apr 19, 2021 · 6 comments · Fixed by #100986
Closed
Assignees
Labels
enhancement New value added to drive a business result Feature:Ingest Node Pipelines Ingest node pipelines management Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@alisonelizabeth
Copy link
Contributor

In elastic/elasticsearch#71625, a new option called extract_device_type was added to the user_agent processor. The Ingest Node Pipelines UI should be updated to support this option.

Docs updated via elastic/elasticsearch#71626.

@alisonelizabeth alisonelizabeth added enhancement New value added to drive a business result Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management labels Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sabarasaba sabarasaba self-assigned this May 27, 2021
@sabarasaba
Copy link
Member

Hey @alisonelizabeth! was wondering if, to your knowledge, theres any special treatment we should apply to this new option given that it's in beta? I thought about doing something like in the screenshots below, but unsure if there are any existing UI patterns for dealing with this.

Screenshot 2021-05-27 at 10 54 32

Screenshot 2021-05-27 at 11 02 10

@alisonelizabeth
Copy link
Contributor Author

alisonelizabeth commented May 27, 2021

Great question! There is a beta badge in EUI that I think could work here if you align it with the toggle label. I'll defer to @dborodyansky though, as I'm not sure if we have more formal design guidelines for beta features.

Would you also mind checking with the ES team as to when this feature should be available? I see the PR is tagged with 7.13, but I don't see it mentioned in the 7.13 docs, only master.

@dborodyansky
Copy link
Contributor

Checked in with design group and beta badge seems appropriate, although a little crowded in the current layout. There is also an icon-only version to consider which is lighter weight, but not as clear at a glance in my opinion.

image

@dborodyansky
Copy link
Contributor

Just learned that a size prop for beta badge is being added soon, and we could use the small size for better fit once released. elastic/eui#4798

@sabarasaba
Copy link
Member

@dborodyansky It does look a bit crowded indeed, but does feel more clear than just the icon. I'll leave that for now and will patch it up in a subsequent PR once that new size prop is available.

@alisonelizabeth Will definitely follow up with them, thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Ingest Node Pipelines Ingest node pipelines management Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants