Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] ci(signed-commits): use GPG signing (backport #13069) #13092

Merged
merged 2 commits into from
May 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 7, 2024

Motivation/summary

Support signed commits using a GPG linked to the user used for the automation.

I double-checked different alternatives as explained in actions/runner#667

But decided to use a native GitHub action for the sake of simplicity; eventually, we could use the GitHub graphql approach, but I don't know if that behaviour will change in the future. For now, I think it's safer to use the default standard approach.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Part of #12995


This is an automatic backport of pull request #13069 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner May 7, 2024 13:06
@mergify mergify bot added the backport label May 7, 2024
@mergify mergify bot assigned v1v May 7, 2024
@v1v v1v enabled auto-merge (squash) May 7, 2024 13:31
@mergify mergify bot merged commit 9a8b0bf into 8.14 May 7, 2024
11 checks passed
@mergify mergify bot deleted the mergify/bp/8.14/pr-13069 branch May 7, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant