Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(signed-commits): use GPG signing #13069

Merged
merged 6 commits into from
May 7, 2024
Merged

ci(signed-commits): use GPG signing #13069

merged 6 commits into from
May 7, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented May 2, 2024

Motivation/summary

Support signed commits using a GPG linked to the user used for the automation.

I double-checked different alternatives as explained in actions/runner#667

But decided to use a native GitHub action for the sake of simplicity; eventually, we could use the GitHub graphql approach, but I don't know if that behaviour will change in the future. For now, I think it's safer to use the default standard approach.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Part of #12995

Copy link
Contributor

mergify bot commented May 2, 2024

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 2, 2024
@v1v
Copy link
Member Author

v1v commented May 2, 2024

Test

I tried these changes in a test feature-branch and

image image

@v1v v1v marked this pull request as ready for review May 2, 2024 10:45
@v1v v1v requested a review from a team as a code owner May 2, 2024 10:45
@v1v v1v self-assigned this May 2, 2024
@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels May 2, 2024
@v1v v1v requested a review from a team May 7, 2024 10:54
@v1v v1v enabled auto-merge (squash) May 7, 2024 11:02
@v1v v1v merged commit 64ec9d5 into elastic:main May 7, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request May 7, 2024
(cherry picked from commit 64ec9d5)

# Conflicts:
#	.github/workflows/run-minor-release.yml
mergify bot pushed a commit that referenced this pull request May 7, 2024
mergify bot pushed a commit that referenced this pull request May 7, 2024
mergify bot added a commit that referenced this pull request May 7, 2024
* ci(signed-commits): use GPG signing (#13069)

(cherry picked from commit 64ec9d5)

* Update .github/workflows/run-patch-release.yml

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
mergify bot added a commit that referenced this pull request May 7, 2024
* ci(signed-commits): use GPG signing (#13069)

(cherry picked from commit 64ec9d5)

* Update .github/workflows/run-patch-release.yml

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
mergify bot added a commit that referenced this pull request May 7, 2024
* ci(signed-commits): use GPG signing (#13069)

(cherry picked from commit 64ec9d5)

# Conflicts:
#	.github/workflows/run-minor-release.yml

* Apply suggestions from code review

---------

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants