test: fix http disabling test #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR elastic#1298 introduced a bug in the tests as it expected the span.type for outgoing http requests to start with `ext.*`. This was changed to `external.*` in the PR elastic#1291, but elastic#1298 was just never updated to be up to date with master before it was merged.
|
Merging without a review to get |
|
Good catch. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1298 introduced a bug in the tests as it expected the span.type for outgoing http requests to start with
ext.*. This was changed toexternal.*in the PR #1291, but #1298 was just never updated to be up to date with master before it was merged.