Skip to content

Commit

Permalink
test: fix http disabling test (#1367)
Browse files Browse the repository at this point in the history
The PR #1298 introduced a bug in the tests as it expected the span.type
for outgoing http requests to start with `ext.*`. This was changed to
`external.*` in the PR #1291, but #1298 was just never updated to be up
to date with master before it was merged.
  • Loading branch information
watson authored Sep 20, 2019
1 parent 130ef6f commit 7c88ca3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/instrumentation/modules/http/disabling.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if (cluster.isMaster) {

function assertSpan (t, span) {
t.ok(/GET localhost:\d+\//.test(span.name), 'span name')
t.equal(span.type, 'ext.http.http', 'span type')
t.equal(span.type, 'external.http.http', 'span type')
}

t.test('incoming enabled + outgoing enabled', makeTest({
Expand Down

0 comments on commit 7c88ca3

Please sign in to comment.