Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/10868 extract seatadjuster app #25

Merged
merged 22 commits into from
Sep 5, 2022
Merged

Feature/10868 extract seatadjuster app #25

merged 22 commits into from
Sep 5, 2022

Conversation

dennismeister93
Copy link
Contributor

@dennismeister93 dennismeister93 commented Aug 29, 2022 •
edited
Loading

Description

Remove SeatAdjuster App and extract to SDK repository example folder
Provide a useful skeleton to the template repository
Add possibility to add SDK examples

!! SDK PR needs to be merged first eclipse-velocitas/vehicle-app-python-sdk#18 !!

Azure DevOps PBI/Task reference

AB#[10868]

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

dennismeister93 and others added 20 commits August 17, 2022 15:32
@dennismeister93
[10802] Improve local runtime scripts
b08bfb9 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
[10802] Fix linting
3eb049f 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Create Skeleton app and extract seat-adjuster to sdk
4ffc8b8 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@emsameen @dennismeister93
[11025/11031] fix GitHub workflow to support external contributors (e…
2cd15e9 
…clipse-velocitas#23)

* fix: fix GitHub workflow to support external contributors

* fix: update the name of the notice file

* fix: rename deployment script to deploy_image_from_artifact.sh
@emsameen @dennismeister93
fix: remove head_refs from all readonly jobs (eclipse-velocitas#24)
ed6b533
@dennismeister93 @emsameen
[10802] Improve local runtime scripts (eclipse-velocitas#17)
95a5b72 
* [10802] Improve local runtime scripts

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [10802] Fix linting

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [11025/11031] fix GitHub workflow to support external contributors (eclipse-velocitas#23)

* fix: fix GitHub workflow to support external contributors

* fix: update the name of the notice file

* fix: rename deployment script to deploy_image_from_artifact.sh

* fix: remove head_refs from all readonly jobs (eclipse-velocitas#24)

* Change UTILS_DIRECTORY for consistency

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
@dennismeister93
[10802] Improve local runtime scripts
e6b6b0b 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
[10802] Fix linting
3e14743 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Create Skeleton app and extract seat-adjuster to sdk
6e8c2f7 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Fix rebase issue
19a7771 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Change log level of data received
e6e2db9 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Bump version for sdk requirement
e60c4e6 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Fix merge conflict
2f32345 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Resolve merge conflicts
a827f71 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Adapt to SDK pr findings
5f1960c 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Remove other examples beside seat-adjuster
842362e 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Remove AppManifest.json from root directory
39c795e 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Resolve merge conflicts
957e55f 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Add missing path change
32d44b0 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Fix unit tests in workflow
71a6f5b 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@emsameen emsameen self-requested a review September 5, 2022 14:35
emsameen
emsameen requested changes Sep 5, 2022
View reviewed changes
.vscode/tasks.json Outdated Show resolved Hide resolved
app/AppManifest.json Outdated Show resolved Hide resolved
app/Dockerfile Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
app/tests/integration/integration_test.py Outdated Show resolved Hide resolved
@dennismeister93
Adapt import example app task
6817fd9 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93
Resolve merge conflicts
d67bed2 
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@emsameen emsameen self-requested a review September 5, 2022 15:26
emsameen
emsameen approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emsameen emsameen merged commit 5e1df64 into eclipse-velocitas:main Sep 5, 2022
@emsameen emsameen deleted the feature/10868-extract-seatadjuster-app branch September 5, 2022 15:54
mml5bg pushed a commit that referenced this pull request Oct 10, 2022
@dennismeister93 @emsameen @mml5bg
Feature/10868 extract seatadjuster app (#25)
013cf33 
* [10802] Improve local runtime scripts

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [10802] Fix linting

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Create Skeleton app and extract seat-adjuster to sdk

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [11025/11031] fix GitHub workflow to support external contributors (#23)

* fix: fix GitHub workflow to support external contributors

* fix: update the name of the notice file

* fix: rename deployment script to deploy_image_from_artifact.sh

* fix: remove head_refs from all readonly jobs (#24)

* [10802] Improve local runtime scripts (#17)

* [10802] Improve local runtime scripts

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [10802] Fix linting

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [11025/11031] fix GitHub workflow to support external contributors (#23)

* fix: fix GitHub workflow to support external contributors

* fix: update the name of the notice file

* fix: rename deployment script to deploy_image_from_artifact.sh

* fix: remove head_refs from all readonly jobs (#24)

* Change UTILS_DIRECTORY for consistency

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>

* [10802] Improve local runtime scripts

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [10802] Fix linting

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Create Skeleton app and extract seat-adjuster to sdk

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Fix rebase issue

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Change log level of data received

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Bump version for sdk requirement

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Fix merge conflict

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Adapt to SDK pr findings

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Remove other examples beside seat-adjuster

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Remove AppManifest.json from root directory

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Add missing path change

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Fix unit tests in workflow

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* Adapt import example app task

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emsameen emsameen emsameen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennismeister93 @emsameen