[11025/11031] fix GitHub workflow to support external contributors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emsameen
force-pushed
the
11025-fix_github_workflow
branch
from
0c74b77
to
a7f7c19
Compare
doosuu
requested changes
Aug 26, 2022
doosuu
approved these changes
Aug 26, 2022
dennismeister93
pushed a commit
to SoftwareDefinedVehicle/vehicle-app-python-template
that referenced
this pull request
Aug 29, 2022
…clipse-velocitas#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh
emsameen
added a commit
that referenced
this pull request
Aug 29, 2022
* [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (#24) * Change UTILS_DIRECTORY for consistency Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
dennismeister93
pushed a commit
to SoftwareDefinedVehicle/vehicle-app-python-template
that referenced
this pull request
Aug 29, 2022
…clipse-velocitas#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh
dennismeister93
added a commit
to SoftwareDefinedVehicle/vehicle-app-python-template
that referenced
this pull request
Aug 29, 2022
* [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (eclipse-velocitas#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (eclipse-velocitas#24) * Change UTILS_DIRECTORY for consistency Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
emsameen
pushed a commit
to SoftwareDefinedVehicle/vehicle-app-python-template
that referenced
this pull request
Aug 29, 2022
Signed-off-by: Dennis Meister <dennis.meister@bosch.com> [11025/11031] fix GitHub workflow to support external contributors (eclipse-velocitas#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh fix: remove head_refs from all readonly jobs (eclipse-velocitas#24) [10802] Improve local runtime scripts (eclipse-velocitas#17) * [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (eclipse-velocitas#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (eclipse-velocitas#24) * Change UTILS_DIRECTORY for consistency Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com> [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Create Skeleton app and extract seat-adjuster to sdk Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Fix rebase issue Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Change log level of data received Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Bump version for sdk requirement Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
emsameen
added a commit
that referenced
this pull request
Sep 5, 2022
* [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Create Skeleton app and extract seat-adjuster to sdk Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (#24) * [10802] Improve local runtime scripts (#17) * [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (#24) * Change UTILS_DIRECTORY for consistency Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com> * [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Create Skeleton app and extract seat-adjuster to sdk Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Fix rebase issue Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Change log level of data received Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Bump version for sdk requirement Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Fix merge conflict Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Adapt to SDK pr findings Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Remove other examples beside seat-adjuster Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Remove AppManifest.json from root directory Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Add missing path change Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Fix unit tests in workflow Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Adapt import example app task Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
mml5bg
pushed a commit
that referenced
this pull request
Oct 10, 2022
* fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh
mml5bg
pushed a commit
that referenced
this pull request
Oct 10, 2022
* [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (#24) * Change UTILS_DIRECTORY for consistency Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
mml5bg
pushed a commit
that referenced
this pull request
Oct 10, 2022
* [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Create Skeleton app and extract seat-adjuster to sdk Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (#24) * [10802] Improve local runtime scripts (#17) * [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [11025/11031] fix GitHub workflow to support external contributors (#23) * fix: fix GitHub workflow to support external contributors * fix: update the name of the notice file * fix: rename deployment script to deploy_image_from_artifact.sh * fix: remove head_refs from all readonly jobs (#24) * Change UTILS_DIRECTORY for consistency Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com> * [10802] Improve local runtime scripts Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * [10802] Fix linting Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Create Skeleton app and extract seat-adjuster to sdk Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Fix rebase issue Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Change log level of data received Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Bump version for sdk requirement Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Fix merge conflict Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Adapt to SDK pr findings Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Remove other examples beside seat-adjuster Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Remove AppManifest.json from root directory Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Add missing path change Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Fix unit tests in workflow Signed-off-by: Dennis Meister <dennis.meister@bosch.com> * Adapt import example app task Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Signed-off-by: Dennis Meister <dennis.meister@bosch.com> Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the permission issue of the access rights for external contributors.
Azure DevOps PBI/Task reference
AB#11025 and AB#11031
Checklist
Vehicle App can be started with dapr run and is connecting to vehicle data broker
Vehicle App can process MQTT messages and call the seat service
Vehicle App can be deployed to local K3D and is running
Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.
Extended the documentation in Velocitas repo
Extended the documentation in README.md
Devcontainer can be opened successfully
Devcontainer can be opened successfully behind a corporate proxy
Devcontainer can be re-built successfully
Release workflow is passing