Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove readonly from parameter to prevent maven warning #3110

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 3, 2023

I have not found any reason why these should be parameters + read only especially if there is a user property so simply not mark them as read only.

Fix #2644

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Dec 3, 2023
Copy link

github-actions bot commented Dec 3, 2023

Test Results

   570 files  ±0     570 suites  ±0   3h 27m 50s ⏱️ - 9m 54s
   374 tests ±0     366 ✔️  - 2    6 💤 ±0  1 +1  1 🔥 +1 
1 122 runs  ±0  1 101 ✔️  - 2  19 💤 ±0  1 +1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 8d717d6. ± Comparison against base commit d2219cd.

@laeubi laeubi merged commit ca5b976 into eclipse-tycho:master Dec 3, 2023
7 of 11 checks passed
Copy link

github-actions bot commented Dec 3, 2023

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven ReadOnlyPluginParametersValidator triggered by tycho-p2-publisher
1 participant