Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven ReadOnlyPluginParametersValidator triggered by tycho-p2-publisher #2644

Closed
Bananeweizen opened this issue Jul 20, 2023 · 2 comments · Fixed by #3110
Closed

Maven ReadOnlyPluginParametersValidator triggered by tycho-p2-publisher #2644

Bananeweizen opened this issue Jul 20, 2023 · 2 comments · Fixed by #3110

Comments

@Bananeweizen
Copy link
Contributor

tycho-p2-publisher injects the build qualifier into the Maven model. However, on recent Maven versions that triggers one of the core validators: https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/plugin/internal/ReadOnlyPluginParametersValidator.java

Therefore the goals of the p2-publisher then emit one warning each for having a value set for a read-only property. I'm not sure if there is a good way to work around the validation, but of course I would like to have my build show no warnings.

10:52:36 [INFO] --- tycho-p2-publisher:3.0.5:publish-osgi-ee (default-publish-osgi-ee) @ com.etas.ascet.repository.ease ---
10:52:36 [INFO] Compiling 12 source files to C:\dev\ascet\git\ascet\tests\com.etas.amd.loader.test\target\classes
10:52:36 [WARNING] Parameter 'qualifier' (user property 'buildQualifier') is read-only, must not be used in configuration
10:52:36 [INFO] Published profile IUs: [a.jre.javase 11.0.0]
10:52:36 [INFO] Published profile IUs: [a.jre.javase 17.0.0]
10:52:36 [INFO] 
10:52:36 [INFO] --- tycho-p2-publisher:3.0.5:publish-products (default-publish-products) @ com.etas.ascet.repository.ease ---
10:52:36 [WARNING] Parameter 'qualifier' (user property 'buildQualifier') is read-only, must not be used in configuration
10:52:36 [INFO] 
10:52:36 [INFO] --- tycho-p2-publisher:3.0.5:publish-categories (default-publish-categories) @ com.etas.ascet.repository.ease ---
10:52:36 [WARNING] Parameter 'qualifier' (user property 'buildQualifier') is read-only, must not be used in configuration
10:52:36 [INFO] 
10:52:36 [INFO] --- tycho-p2-publisher:3.0.5:attach-artifacts (default-attach-artifacts) @ com.etas.ascet.repository.ease ---
10:52:36 [WARNING] Parameter 'qualifier' (user property 'buildQualifier') is read-only, must not be used in configuration
10:52:36 [INFO] 
10:52:36 [INFO] --- tycho-p2-repository:3.0.5:assemble-repository (default-assemble-repository) @ com.etas.ascet.repository.ease ---
10:52:36 [WARNING] Parameter 'qualifier' (user property 'buildQualifier') is read-only, must not be used in configuration
10:52:36 [INFO] 
@laeubi
Copy link
Member

laeubi commented Jul 20, 2023

See also this discussion:

Sadly Maven has recently added a lot of validations that emit many warnings for code that previously worked without any issue and without any clear migration guide...

@dhendriks
Copy link
Contributor

So, how to proceed? Can something be done on the Tycho side? Should we report this to Maven? Or what?

laeubi added a commit to laeubi/tycho that referenced this issue Dec 3, 2023
github-actions bot pushed a commit that referenced this issue Dec 3, 2023
laeubi added a commit that referenced this issue Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants