Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mod disable/uninstall status indicator #1182

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Fix mod disable/uninstall status indicator #1182

merged 4 commits into from
Jan 25, 2024
+144 −64

Commits on Jan 25, 2024

  1. Disable buttons when actions are being performed 

    Disable the buttons in the DisableModModal.vue when actions are being
performed.
    @MythicManiac
    MythicManiac committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ad1ff2a View commit details
    Browse the repository at this point in the history

  2. Fix mod management modal overflow 

    The mod management actions modal was overflowing over the screen when
large amounts of content was present.

Fix this issue by creating a ModalCard component which uses the
bulma-provided modal-card CSS classes which appropriately restrict the
overflow to take place only in the card body.

Replace AssociatedModsModal, UninstallModModal, and DisableModModal's
use of Modal with ModalCard, meaning these actions should no longer
overflow off-screen.
    @MythicManiac
    MythicManiac committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9590f81 View commit details
    Browse the repository at this point in the history

  3. Make mod disabling state management more robust 

    Move the UI state resetting of mod disabling actions to a `finally`
clause in the try/catch block as to ensure it's properly reset even if
unexpected errors occur. A failure to reset the state properly will mean
the UI gets stuck.
    @MythicManiac
    MythicManiac committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    bb7c2af View commit details
    Browse the repository at this point in the history

  4. Fix mass-uninstall/disable status feedback 

    The uninstall/disable progress status indicator is overflowing outside
of the modal and mostly not visible. This commit moves it to the modal
body in such a way that it's always visible when intended.
    @MythicManiac
    MythicManiac committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e5e8703 View commit details
    Browse the repository at this point in the history