Fix mod disable/uninstall status indicator #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the buttons in the DisableModModal.vue when actions are being performed.
The mod management actions modal was overflowing over the screen when large amounts of content was present. Fix this issue by creating a ModalCard component which uses the bulma-provided modal-card CSS classes which appropriately restrict the overflow to take place only in the card body. Replace AssociatedModsModal, UninstallModModal, and DisableModModal's use of Modal with ModalCard, meaning these actions should no longer overflow off-screen.
Move the UI state resetting of mod disabling actions to a `finally` clause in the try/catch block as to ensure it's properly reset even if unexpected errors occur. A failure to reset the state properly will mean the UI gets stuck.
The uninstall/disable progress status indicator is overflowing outside of the modal and mostly not visible. This commit moves it to the modal body in such a way that it's always visible when intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added status indicator for mod uninstall / disable progress was not working as intended after other changes were merged in. This PR improves the modal layouts to better accommodate the status indicator and in general deal with overflow better.
Demo:
demo.mp4