additionally use find_package for fastcdr #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a manifest file it is impossible for ament to detect the dependency on `fastcdr` if a non-standard function is being used. Therefore FastRTPS is being built without finding `FastCDR`: http://ci.ros2.org/job/ros2_batch_ci_osx/412/consoleFull#console-section-37 The additional `find_package` call should not have any side effects. I used the same conditional as within the `find_eprosima_package` macro.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a manifest file it is impossible for ament to detect the dependency on
fastcdrif a non-standard function is being used. Therefore FastRTPS is being built without findingFastCDR: http://ci.ros2.org/job/ros2_batch_ci_osx/412/consoleFull#console-section-37The additional
find_packagecall should not have any side effects. I used the same conditional as within thefind_eprosima_packagemacro.