Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various warnings on Windows #43

Closed
wants to merge 3 commits into from
Closed

fix various warnings on Windows #43

wants to merge 3 commits into from

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Jun 3, 2016

@richiprosima
Copy link
Contributor

Hi @dirk-thomas

I will close your PR for several reasons:

  • Your commit @15daf480a7 solves a problem generated by an old version of
    Boost. But with the last one version these changes are not necessary.
  • Your commit @96201d1e52 is deprecated because in new release 1.2.0
    AsyncWriterThread was refactored to support more functionality.
  • Your commit @578e91a79 was added by us in commit @578e91a79 before the change to Apache License
    2.0. Sorry for the inconveniences.

Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants