SubscriberHistory: best effort reader w/KEEP_LAST_HISTORY_QOS does not overwrite last sample #41
Comments
liamstask
added a commit
to 3drobotics/Fast-RTPS
that referenced
this issue
Apr 29, 2016
Previously, when `m_isHistoryFull` is true, samples would not be removed even when `m_historyQos.kind` is `KEEP_LAST_HISTORY_QOS`. There is a similar problem in the `WITH_KEY` block, which this change does not address. for eProsima#41
Closed
|
We will check it in current development branch before next release. |
|
New release is out, tests indicate this issue has been solved. Cheers! |
12 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
same pub/sub attributes as #39.
If I publish 2 samples, then take from the subscriber, I receive sample 1 not sample 2 as expected with
KEEP_LAST_HISTORY_QOS.The check for
if(m_isHistoryFull)inSubscriberHistory::received_change()prevents the logic that handlesKEEP_LAST_HISTORY_QOSfrom removing samples to make space for the new sample. If I remove that check, the take works as expected (but will not work forKEEP_ALL_HISTORY_QOSreaders).The text was updated successfully, but these errors were encountered: