add precommit callback #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dydxwill
requested review from
prettymuchbryce,
vincentwschau and
Christopher-Li
prettymuchbryce
approved these changes
Feb 23, 2023
baseapp/baseapp.go
Outdated
| @@ -70,6 +70,7 @@ type BaseApp struct { //nolint: maligned | |||
| prepareProposal sdk.PrepareProposalHandler // the handler which runs on ABCI PrepareProposal | |||
| endBlocker sdk.EndBlocker // logic to run after all txs, and to determine valset changes | |||
| commiter sdk.Commiter // logic to run during commit | |||
| precommiter sdk.Precommiter // logic to run during precommit | |||
There was a problem hiding this comment.
nit:
Suggested change
| precommiter sdk.Precommiter // logic to run during precommit | |
| precommiter sdk.Precommiter // logic to run during commit using the `deliverState` |
types/abci.go
Outdated
| @@ -23,6 +23,10 @@ type EndBlocker func(ctx Context, req abci.RequestEndBlock) abci.ResponseEndBloc | |||
| // branched for the new block. | |||
| type Commiter func(ctx Context) | |||
|
|
|||
| // Precommiter runs code during commit before the `deliverState` is reset. For the Dydx chain, it is currently | |||
There was a problem hiding this comment.
nit: Remove the dYdX specific comment. I think we can include this context downstream in v4.
19 tasks
prettymuchbryce
pushed a commit
that referenced
this pull request
Feb 28, 2023
prettymuchbryce
pushed a commit
that referenced
this pull request
Feb 28, 2023
dydxwill
added a commit
that referenced
this pull request
Mar 20, 2023
prettymuchbryce
pushed a commit
that referenced
this pull request
Mar 22, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 23, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 23, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 23, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 23, 2023
jonfung-dydx
added a commit
that referenced
this pull request
Mar 24, 2023
* Implement Commiter * Update README with fork instructions * Enable CI workflows and fix failures (#4) * Fix lint/gocritic error * Disable some workflow jobs * Add tests for Commiter change (#5) * Add additional upgrade step to README * add precommit callback (#7) * Revert "add precommit callback (#7)" (#10) This reverts commit 0e85c49. * cosmos-sdk upgrade README changes --------- Co-authored-by: Bryce Neal <bryce@dydx.exchange> Co-authored-by: Bryce Neal <brycedneal@gmail.com> Co-authored-by: dydxwill <119354122+dydxwill@users.noreply.github.com>
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 24, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 24, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 28, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 28, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 28, 2023
jonfung-dydx
pushed a commit
that referenced
this pull request
Mar 28, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jun 30, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jun 30, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jul 1, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jul 1, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jul 2, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jul 3, 2023
roy-dydx
pushed a commit
that referenced
this pull request
Jul 3, 2023
lcwik
pushed a commit
that referenced
this pull request
Aug 24, 2023
lcwik
added a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precommit callback will be used for emitting Indexer onchain events from the deliverState