Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI workflows and fix failures #4

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Enable CI workflows and fix failures #4

merged 2 commits into from
Feb 3, 2023

Conversation

prettymuchbryce
Copy link

@prettymuchbryce prettymuchbryce commented Jan 31, 2023 •
edited
Loading

This PR enables workflows in CI for our cosmos-sdk fork and fixes failures.

Many of the actions weren't being run due to our GitHub security settings. So I needed to whitelist a number of workflows to get them to run. So this is why nothing was running in previous PRs.

Once I whitelisted the necessary workflows, I noticed these issues, which is what I fixed in this PR.

@prettymuchbryce prettymuchbryce force-pushed the prettymuchbryce/fix-ci branch 2 times, most recently from e07cb8d to 169108e Compare January 31, 2023 20:52
@prettymuchbryce prettymuchbryce changed the title Debug CI issues Enable CI workflows and fix failures Feb 2, 2023
prettymuchbryce
prettymuchbryce commented Feb 3, 2023
View reviewed changes
.github/workflows/sims.yml
@@ -84,7 +84,7 @@ jobs:
needs:
[test-sim-multi-seed-short, test-sim-after-import, test-sim-import-export]
runs-on: ubuntu-latest
if: ${{ success() }}
if: ${{ false }} # Disabled due to requiring Slack integration
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ideal to continue to run the sim tests above, but these two jobs require a SLACK_WEBHOOK which pipes failures and successes into slack. I think this would just be noise for us for now so I'd prefer not to do this.

prettymuchbryce
prettymuchbryce commented Feb 3, 2023
View reviewed changes
.github/workflows/test.yml
@@ -161,6 +161,7 @@ jobs:
path: ./tests/e2e-profile.out

repo-analysis:
if: ${{ false }} # Disabled due to requiring SonarCloud integration
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ideal to continue to run the tests above, but this require a SONAR_TOKEN for SonarCloud. I think this isn't necessary for us so I'd prefer not to set this up.

prettymuchbryce
prettymuchbryce commented Feb 3, 2023
View reviewed changes
server/util.go
@@ -146,11 +146,12 @@ func InterceptConfigsPreRunHandler(cmd *cobra.Command, customAppConfigTemplate s
}

var logger tmlog.Logger
if config.LogFormat == tmcfg.LogFormatJSON {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing lint failures.

@prettymuchbryce prettymuchbryce marked this pull request as ready for review February 3, 2023 13:40
@prettymuchbryce prettymuchbryce merged commit 5b62aa5 into dydx-fork-v0.47.0-alpha2 Feb 3, 2023
@prettymuchbryce prettymuchbryce deleted the prettymuchbryce/fix-ci branch February 3, 2023 15:01
prettymuchbryce added a commit that referenced this pull request Feb 28, 2023
@prettymuchbryce
Enable CI workflows and fix failures (#4)
5fd472b 
* Fix lint/gocritic error

* Disable some workflow jobs
prettymuchbryce added a commit that referenced this pull request Feb 28, 2023
@prettymuchbryce
Enable CI workflows and fix failures (#4)
0e7ab87 
* Fix lint/gocritic error

* Disable some workflow jobs
jonfung-dydx pushed a commit that referenced this pull request Mar 23, 2023
@prettymuchbryce @jonfung-dydx
Enable CI workflows and fix failures (#4)
8e03b8a 
* Fix lint/gocritic error

* Disable some workflow jobs
jonfung-dydx added a commit that referenced this pull request Mar 24, 2023
@jonfung-dydx @prettymuchbryce @dydxwill
Add dYdX commits to cosmos v0.47.1 (#11)
0c25c44 
* Implement Commiter

* Update README with fork instructions

* Enable CI workflows and fix failures (#4)

* Fix lint/gocritic error

* Disable some workflow jobs

* Add tests for Commiter change (#5)

* Add additional upgrade step to README

* add precommit callback (#7)

* Revert "add precommit callback (#7)" (#10)

This reverts commit 0e85c49.

* cosmos-sdk upgrade README changes

---------

Co-authored-by: Bryce Neal <bryce@dydx.exchange>
Co-authored-by: Bryce Neal <brycedneal@gmail.com>
Co-authored-by: dydxwill <119354122+dydxwill@users.noreply.github.com>
jonfung-dydx pushed a commit that referenced this pull request Mar 24, 2023
@prettymuchbryce @jonfung-dydx
Enable CI workflows and fix failures (#4)
ffc969e 
* Fix lint/gocritic error

* Disable some workflow jobs
jonfung-dydx pushed a commit that referenced this pull request Mar 28, 2023
@prettymuchbryce @jonfung-dydx
Enable CI workflows and fix failures (#4)
fc7c264 
* Fix lint/gocritic error

* Disable some workflow jobs
roy-dydx pushed a commit that referenced this pull request Jun 30, 2023
@prettymuchbryce @roy-dydx
Enable CI workflows and fix failures (#4)
6640029 
* Fix lint/gocritic error

* Disable some workflow jobs
roy-dydx pushed a commit that referenced this pull request Jul 1, 2023
@prettymuchbryce @roy-dydx
Enable CI workflows and fix failures (#4)
312707d 
* Fix lint/gocritic error

* Disable some workflow jobs
roy-dydx pushed a commit that referenced this pull request Jul 2, 2023
@prettymuchbryce @roy-dydx
Enable CI workflows and fix failures (#4)
ae50d79 
* Fix lint/gocritic error

* Disable some workflow jobs
roy-dydx pushed a commit that referenced this pull request Jul 3, 2023
@prettymuchbryce @roy-dydx
Enable CI workflows and fix failures (#4)
21463de 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Aug 24, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
f598c3c 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Aug 24, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
c3b3261 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Aug 24, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
8f1ab55 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Aug 25, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
a5d108b 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Sep 5, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
ec85e30 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Dec 4, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
9510f1c 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Dec 6, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
17a4364 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Jan 17, 2024
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
4d3140b 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik pushed a commit that referenced this pull request Jan 22, 2024
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (#4)
b92c2ff 
* Fix lint/gocritic error

* Disable some workflow jobs
roy-dydx pushed a commit that referenced this pull request Feb 20, 2024
@prettymuchbryce @roy-dydx
Enable CI workflows and fix failures (#4)
9a021b6 
* Fix lint/gocritic error

* Disable some workflow jobs
lcwik added a commit that referenced this pull request Feb 26, 2024
@lcwik
# This is a combination of 5 commits.
064329f 
# This is the 1st commit message:

Enable locking kv store

# The commit message #2 will be skipped:

# Fix some lock orderings

# The commit message #3 will be skipped:

# Fix minor typo

# The commit message #4 will be skipped:

# Ensure that writes happen in a deterministic order.
#
# Ensure that reads are also done all the time, remove this if it doesn't impact gas.

# The commit message #5 will be skipped:

# Remove locking for now for lockingkv.Get/Has
lcwik added a commit that referenced this pull request Feb 26, 2024
@lcwik
# This is a combination of 5 commits.
3fe1d6c 
# This is the 1st commit message:

Enable locking kv store

# The commit message #2 will be skipped:

# Fix some lock orderings

# The commit message #3 will be skipped:

# Fix minor typo

# The commit message #4 will be skipped:

# Ensure that writes happen in a deterministic order.
#
# Ensure that reads are also done all the time, remove this if it doesn't impact gas.

# The commit message #5 will be skipped:

# Remove locking for now for lockingkv.Get/Has
roy-dydx pushed a commit that referenced this pull request Mar 26, 2024
@prettymuchbryce @roy-dydx
Enable CI workflows and fix failures (#4)
e33736b 
* Fix lint/gocritic error

* Disable some workflow jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayy04 jayy04 jayy04 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prettymuchbryce @jayy04