-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Structopt with Clap v3 #216
Conversation
0ab7ea6
to
d490553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how some of our custom logic is handled by clap now.
Hmm, it seems clap-rs/clap#3232 didn't completely fix clap-rs/clap#3215
Edit: I managed to work around this issue by passing |
It's outside the scope of this PR, but custom help headings may be interesting. |
Looks interesting.
But I agree it is better to explore the |
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
NO_COLOR
check.{n}
at the end of each long help.ssl2.3
option for--ssl
and1
for--http-version
.USAGE
string. See Is it possible to not show usage string in post validation errors? clap-rs/clap#3227 (comment).