Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for clap v3 #152

Closed
4 tasks
blyxxyz opened this issue Jun 5, 2021 · 4 comments · Fixed by #216
Closed
4 tasks

Fixes for clap v3 #152

blyxxyz opened this issue Jun 5, 2021 · 4 comments · Fixed by #216

Comments

@blyxxyz
Copy link
Collaborator

blyxxyz commented Jun 5, 2021 •
edited
Loading

There are a few bugs and workarounds that we can get rid of after clap 3 releases.

There are probably others I can't remember at the moment.
@ducaale
Copy link
Owner

ducaale commented Jun 5, 2021 •
edited
Loading

We can also get rid of the triple {n} we have after each long help text

Edit: There is also support for hiding some of the possible values. See clap-rs/clap#3061.

@blyxxyz
Copy link
Collaborator Author

blyxxyz commented Dec 9, 2021

A release candidate is out.

Its MSRV is 1.54, so we'll have to bump our own to use it.

@ducaale
Copy link
Owner

ducaale commented Dec 31, 2021

Clap v3.0 has now been officially released 🎉.

See https://epage.github.io/blog/2021/12/clap3/.

@ducaale ducaale linked a pull request Mar 8, 2022 that will close this issue
Replace Structopt with Clap v3 #216
Merged
@ducaale
Copy link
Owner

ducaale commented Mar 8, 2022

I will close this issue since these fixes are now in develop.

@ducaale ducaale closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Structopt with Clap v3 ducaale/xh
2 participants
@blyxxyz @ducaale