Fixing sqlalchemy deprecation error #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Alchemist
force-pushed
the
remove.sqlalchemy.deprecation.error
branch
from
7f5e696
to
2ec744d
Compare
elukey
added a commit
to elukey/PyHive
that referenced
this pull request
Feb 20, 2020
Calls to the reflecttable() method are complaining about the absence of resolve_fks when sqlalchemy>=1.3.0 is used. 'Binary' is deprecated. Replacing it with 'LargeBinary' to incorporate changes in pull request dropbox#293. issue dropbox#288
Closed
bkyryliuk
pushed a commit
that referenced
this pull request
Feb 21, 2020
* Fix CI errors reported Travis is currently reporting some errors: 1) sqlalchemy 1.3 seems to have introduced a new positional arg called resolve_fks for reflect, that causes CI to fail when sqlalchemy installed by pypi is greater than 1.2.8. It seems out of scope to migrate PyHive to sqlalchemy 1.3.0, so I just added some safeguards in setup.py and travis config to avoid the new version. 2) urllib.util.parse_url seems to refuse to parse http://localhost:99999, raising an exception that is not the one expected in the test. Fixed the port with 9999. 3) WAITING_FOR_RESOURCES, QUEUED can be states of a Presto query, add them to the test. Issue #288 * Bump sqlalchemy dependencies to 1.3.0 Calls to the reflecttable() method are complaining about the absence of resolve_fks when sqlalchemy>=1.3.0 is used. 'Binary' is deprecated. Replacing it with 'LargeBinary' to incorporate changes in pull request #293. issue #288
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.