Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.6.2 #288

Closed
BenoitHanotte opened this issue Jun 7, 2019 · 11 comments
Closed

Release 0.6.2 #288

BenoitHanotte opened this issue Jun 7, 2019 · 11 comments

Comments

@BenoitHanotte
Copy link

Hello,
The latest release (0.6.1) has been made in September 2018, yet there has been some significant additions since then, for instance kerberos support for Presto (#229). Would it be possible to consider releasing version 0.6.2?
Thanks!
@elukey
Copy link
Contributor

elukey commented Dec 5, 2019

Any update on this? I see that there is https://pypi.org/project/HerePyHive/, updated to 0.6.2, not sure who created it, but might be the only alternative?

@elukey elukey mentioned this issue Dec 9, 2019
Closed
@elukey
Copy link
Contributor

elukey commented Feb 20, 2020 •
edited
Loading

@bkyryliuk the difference between 0.6.1 (last release on Pypi) and master is about 3 commits:

v0.6.1...master

CI seems broken for the past three commits:
https://travis-ci.org/dropbox/PyHive/jobs/652716753?utm_medium=notification&utm_source=github_status

It seems started after 14faef9, that seems related to the failures that Travis shows. Maybe tests need to be updated?

elukey added a commit to elukey/PyHive that referenced this issue Feb 20, 2020
@elukey
Fix CI errors reported
e1d366b 
Travis is currently reporting some errors:
1) sqlalchemy 1.3 seems to have introduced a new positional arg called resolve_fks
   for reflect, that causes CI to fail when sqlalchemy installed by pypi is greater
   than 1.2.8. It seems out of scope to migrate PyHive to sqlalchemy 1.3.0, so I just
   added some safeguards in setup.py and travis config to avoid the new version.
2) urllib.util.parse_url seems to refuse to parse http://localhost:99999, raising an
   exception that is not the one expected in the test. Fixed the port with 9999.
3) WAITING_FOR_RESOURCES, QUEUED can be states of a Presto query, add them to the test.

Issue dropbox#288
@elukey elukey mentioned this issue Feb 20, 2020
Merged
elukey added a commit to elukey/PyHive that referenced this issue Feb 20, 2020
@elukey
Bump sqlalchemy dependencies to 1.3.0
edb798d 
Calls to the reflecttable() method are complaining about the absence of
resolve_fks when sqlalchemy>=1.3.0 is used.

issue dropbox#288
elukey added a commit to elukey/PyHive that referenced this issue Feb 20, 2020
@elukey
Bump sqlalchemy dependencies to 1.3.0
1914b21 
Calls to the reflecttable() method are complaining about the absence of
resolve_fks when sqlalchemy>=1.3.0 is used.

issue dropbox#288
elukey added a commit to elukey/PyHive that referenced this issue Feb 20, 2020
@elukey
Bump sqlalchemy dependencies to 1.3.0
32af6f5 
Calls to the reflecttable() method are complaining about the absence of
resolve_fks when sqlalchemy>=1.3.0 is used.
'Binary' is deprecated. Replacing it with 'LargeBinary' to incorporate
changes in pull request dropbox#293.

issue dropbox#288
@elukey
Copy link
Contributor

elukey commented Feb 20, 2020

I created two commits (see the pull request) that are aimed to 1) fix the CI issue 2) bump sqlalchemy to 1.3.0+.

I checked the list of pull requests and I found some that are interesting to review/test/merge for 0.6.2, since they are kerberos-related:

#309
#289
#227

When bumping sqlalchemy to 1.3.0 I also incorporated #293

Disclaimer: I am not saying that all the other pull requests are less important, I am only trying to help out to release 0.6.2 :)

@bkyryliuk
Copy link
Collaborator

great, I'll work on reviewing & getting them merged.

bkyryliuk pushed a commit that referenced this issue Feb 21, 2020
@elukey
Fix CI errors reported (#312)
9265b58 
* Fix CI errors reported

Travis is currently reporting some errors:
1) sqlalchemy 1.3 seems to have introduced a new positional arg called resolve_fks
   for reflect, that causes CI to fail when sqlalchemy installed by pypi is greater
   than 1.2.8. It seems out of scope to migrate PyHive to sqlalchemy 1.3.0, so I just
   added some safeguards in setup.py and travis config to avoid the new version.
2) urllib.util.parse_url seems to refuse to parse http://localhost:99999, raising an
   exception that is not the one expected in the test. Fixed the port with 9999.
3) WAITING_FOR_RESOURCES, QUEUED can be states of a Presto query, add them to the test.

Issue #288

* Bump sqlalchemy dependencies to 1.3.0

Calls to the reflecttable() method are complaining about the absence of
resolve_fks when sqlalchemy>=1.3.0 is used.
'Binary' is deprecated. Replacing it with 'LargeBinary' to incorporate
changes in pull request #293.

issue #288
@elukey
Copy link
Contributor

elukey commented Mar 4, 2020

@bkyryliuk what do you think about releasing 0.6.2?

@elukey
Copy link
Contributor

elukey commented Mar 4, 2020

Correcting myself - I am now testing this PyHive version with Superset + Presto + Kerberos, will report back if everything works first :)

@bkyryliuk
Copy link
Collaborator

@elukey let me know how the test goes, happy to cut the release after

@elukey
Copy link
Contributor

elukey commented Mar 5, 2020 •
edited
Loading

@elukey let me know how the test goes, happy to cut the release after

@bkyryliuk All good, I am able to use Presto + Kerberos + Https self signed certs with Superset :)

@VinceDPM
Copy link

@bkyryliuk Is it possible to merge this PR to be included with 0.6.2?
#246
Or does this PR need more work to be included?

@bkyryliuk
Copy link
Collaborator

bkyryliuk commented Mar 11, 2020 via email

@bkyryliuk
Copy link
Collaborator

Released: https://pypi.org/project/PyHive/0.6.2/

Please let me know if you'll have / see any issues.
Apologies for the delay!
It was a bit crazy lately in SF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elukey @bkyryliuk @BenoitHanotte @VinceDPM