-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add hooks ED_Alloc()
& ED_Free()
.
#867
API: Add hooks ED_Alloc()
& ED_Free()
.
#867
Conversation
I guess you have to add in Like here: 81fe334#diff-d65c6e4e25d9b3976051fc1605a2a6711248b2ee520dfc321967f472d2857329R518 also in |
Adding the API functions as "function call" is not needed, calling "pfnCreateEntity" & "pfnRemoveEntity" trigger them directly and so, the hooks will be. The hooks are already in "class CRehldsHookchains : public IRehldsHookchains", I do not think I have missed something. Thanks for having quickly reviewed & approved them, appreciated! PS: You can move it from "To do" list to "Done" in the "Projects"! |
Now all that's left is for someone to implement them on ReAPI as well as to have the GetEntityInit hook available. |
Why you do not just merge the PR without s1lentq review, especially knowing you got the repository rights? The changes are not complexes & I think you know all is good (& understand the code). And one more question: Can you merge it in force even if you asked s1lentq's review and if he do not review it? The fact is, I have difficulties to understand why some PRs which seem good & "finalized" are often dormant, and sometimes for months, for all the Re* projects. |
ED_Alloc
& ED_Free
.
ED_Alloc
& ED_Free
.ED_Alloc()
& ED_Free()
.
I guess I have my answer for my second question! It is "yes you can!" Hehehehehe! Now you can merge a few others PRs ready, then make a release! |
Addition of new & useful API hooks related to the start & end points of the entity creation/removal.
Please add this QUICKLY! With the others of @francoromaniello at the same time! Hahaha!