Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Con_Printf() hook #861

Merged
merged 7 commits into from
Oct 24, 2021

Conversation

francoromaniello
Copy link
Contributor

Related to s1lentq/reapi#219

@StevenKal
Copy link
Contributor

@francoromaniello (out of subject): Can you add the "ED_Free" hook too please? This is in the "to do" list but forgotten... Thank you in advance.

@DarthMan
Copy link

DarthMan commented Oct 18, 2021

Would also be cool to add ED_Alloc, if possible, as well as hooks to ReAPI.

@StevenKal
Copy link
Contributor

@francoromaniello: No need you do it, because I just did in #867 via my laptop, but you might need to do it for people who want it in the AMXX's ReAPI module (DarthMan for example), me I will not as "AMXX stuff" is not my business...

@francoromaniello
Copy link
Contributor Author

Can you stop mentioning me in multiple pulls? You can easily go to my profile get my email and send me an email and a plus is that you do not generate off-topic
btw
I have no relationship with those who manage the repositories, I'm not customer service or anything like that.

Thanks. :3

@StevenKal
Copy link
Contributor

I mentionned you like 3 times from that I recall, the both here were justified, the first to ask you something like if I could do it via emailing you since I "had the feeling" you were O.K. for multiple hooks addition (as some people requested them & you did right after...), or this was "a thing you liked to do", and the second was to inform you to do not make the "ED_Free" hook since I found some motivation to use my weak laptop on W7 in order to do it myself, and I will not bother you anymore, I will do them myself in the future.
There is only on #867 this was not needed, I probably mistaken by adding the "too much" "@" in front of your name, sorry if I bothered you with this.

@wopox1337 wopox1337 changed the title Implement Con_Printf hook Implement Con_Printf() hook Oct 20, 2021
StevenKal referenced this pull request Oct 22, 2021
* Update pr_edict.h

* Update pr_edict.cpp

* Update rehlds_api_impl.cpp

* Update rehlds_api_impl.h

* Update rehlds_api.h

* Update pr_edict.h

* Update pr_edict.cpp

* Update rehlds_api_impl.cpp

* Update rehlds_api_impl.h

* Update rehlds_api.h

* Update pr_edict.cpp
rehlds/engine/sys_dll.cpp Outdated Show resolved Hide resolved
rehlds/engine/sys_dll.h Outdated Show resolved Hide resolved
rehlds/public/rehlds/rehlds_api.h Outdated Show resolved Hide resolved
@wopox1337 wopox1337 merged commit 471158b into dreamstalker:master Oct 24, 2021
@francoromaniello francoromaniello deleted the Con_Printf branch October 24, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants