Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] HybridGlobalization, add not supported APIs #95920

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[doc] HybridGlobalization, add not supported APIs #95920

merged 1 commit into from
Dec 12, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Dec 12, 2023 •
edited
Loading

Follow up for #95324 (comment). It will require a fix, there is too many public APIs that are throwing, especially among methods connected to collections. Connected issue: #95921

@ilonatommy ilonatommy self-assigned this Dec 12, 2023
@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up for #95324 (comment). It will require a fix, there is too many public APIs that are throwing, especially among methods connected to collections. Connected issue: ...

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization
Milestone: -

@ilonatommy ilonatommy mentioned this pull request Dec 12, 2023
Open
matouskozak
matouskozak approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@matouskozak matouskozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the indirectly affected APIs. Let's investigate how we can enable SortKey functionality in HybridMode to not throw exception.

@ilonatommy ilonatommy merged commit 2df188c into dotnet:main Dec 12, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matouskozak matouskozak matouskozak approved these changes

@radical radical Awaiting requested review from radical

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilonatommy @matouskozak