Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Limit PNSE in HybridGlobalization #95921

Open
ilonatommy opened this issue Dec 12, 2023 · 1 comment
Open

[browser] Limit PNSE in HybridGlobalization #95921

ilonatommy opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Dec 12, 2023

#95920 updated the doc with APIs that are throwing PlatformNotSupportedException by design. Consider:

  • implementing invariant SortKey in HybridGlobalization
  • changing comparison options to supported ones.

SortKey:

  • JS does not expose API that would give us similar information to SortKey
  • Intl.Collator-based implementation of SortKey could be an alternative to the original, locale-sensitive SortKey. However, we have no guarantee that the implementation would give similar results and would not cost us too much space.
  • Invariant SortKey does not cover fully the original, locale-sensitive functionality, however it is the best alternative when it comes to saving space - it's already implemented, we would reuse existing code. Document the changes in behavior.

CompareOptions:

  • some combinations of compare options are not supported (see the doc)
  • APIs in other, non-globalization libs use these combinations, becoming not supported
  • Check if they would not work equally good with another compare options set that is supported and document the changes in behavior.

Old issue discussing the possibilities:
#84621

@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

#95920 updated the doc with APIs that are throwing PlatformNotSupportedException by design. Consider:

  • implementing invariant SortKey in HybridGlobalization
  • changing comparison options to supported ones.

SortKey:

  • JS does not expose API that would give us similar information to SortKey
  • Intl.Collator-based implementation of SortKey could be an alternative to the original, locale-sensitive SortKey. However, we have no guarantee that the implementation would give similar results and would not cost us too much space.
  • Invariant SortKey does not cover fully the original, locale-sensitive functionality, however it is the best alternative when it comes to saving space - it's already implemented, we would reuse existing code. Document the changes in behavior.

CompareOptions:

  • some combinations of compare options are not supported (see the doc)
  • APIs in other, non-globalization libs use these combinations, becoming not supported
  • Check if they would not work equally good with another compare options set that is supported and document the changes in behavior.
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-System.Globalization

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 12, 2023
@radical radical removed the untriaged New issue has not been triaged by the area owner label Dec 13, 2023
@ilonatommy ilonatommy self-assigned this Dec 19, 2023
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Dec 29, 2023
@lewing lewing modified the milestones: 9.0.0, Future May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants