Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling Linux Bionic tests that fail on staging. #72256

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Disabling Linux Bionic tests that fail on staging. #72256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ce0fed
Disabling LinuxBionic tests that fail on staging.
ilonatommy Jul 15, 2022
c2abac6
Attempt 2.
ilonatommy Jul 15, 2022
d2c78a5
Fix 3 - partial, w/o SpecialFile_Unelevated_Throws
ilonatommy Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ private static bool GetAlpnSupport()

public static bool SupportsAlpn => s_supportsAlpn.Value;
public static bool SupportsClientAlpn => SupportsAlpn || IsOSX || IsMacCatalyst || IsiOS || IstvOS;
public static bool SupportsHardLinkCreation => !IsAndroid;
public static bool SupportsHardLinkCreation => !IsAndroid && !IsLinuxBionic;

private static readonly Lazy<bool> s_supportsTls10 = new Lazy<bool>(GetTls10Support);
private static readonly Lazy<bool> s_supportsTls11 = new Lazy<bool>(GetTls11Support);
Expand Down
2 changes: 1 addition & 1 deletion ...braries/System.Formats.Tar/tests/TarReader/TarReader.TarEntry.ExtractToFile.Tests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Formats.Tar.Tests
{
public partial class TarReader_TarEntry_ExtractToFile_Tests : TarTestsBase
{
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.tvOS)] // https://github.com/dotnet/runtime/issues/68360
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.tvOS & ~TestPlatforms.LinuxBionic)] // https://github.com/dotnet/runtime/issues/68360
[ConditionalFact(nameof(IsUnixButNotSuperUser))]
public void SpecialFile_Unelevated_Throws()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@directhex any idea why this might fail on Linux Bionic but apparently not on Android?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not offhand

{
Expand Down
2 changes: 1 addition & 1 deletion ...es/System.Formats.Tar/tests/TarReader/TarReader.TarEntry.ExtractToFileAsync.Tests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Formats.Tar.Tests
{
public partial class TarReader_TarEntry_ExtractToFileAsync_Tests : TarTestsBase
{
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.tvOS)] // https://github.com/dotnet/runtime/issues/68360
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.tvOS & ~TestPlatforms.LinuxBionic)] // https://github.com/dotnet/runtime/issues/68360
[ConditionalFact(nameof(IsUnixButNotSuperUser))]
public async Task SpecialFile_Unelevated_Throws_Async()
{
Expand Down