Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling Linux Bionic tests that fail on staging. #72256

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Disabling Linux Bionic tests that fail on staging. #72256

merged 3 commits into from
Jul 15, 2022

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 15, 2022 •
edited
Loading

Connected Issue: #68360.
PRs after merging with main started failing in runtime-staging job on System.Formats.Tar tests - platforms net7.0-Linux-Release-x64-Mono_Release_LinuxBionic-Ubuntu.1804.Amd64.Android.29.Open and net7.0-Linux-Release-arm64-Mono_Release_LinuxBionic-Windows.10.Amd64.Android.Open:

   Finished:    System.Formats.Tar.Tests
                 === TEST EXECUTION SUMMARY ===
                    System.Formats.Tar.Tests  Total: 871, Errors: 0, Failed: 10, Skipped: 8, Time: 8.624s
                 
                 
                 Std err:
                     System.Formats.Tar.Tests.TarReader_TarEntry_ExtractToFileAsync_Tests.SpecialFile_Unelevated_Throws_Async [FAIL]
                     System.Formats.Tar.Tests.TarReader_TarEntry_ExtractToFile_Tests.SpecialFile_Unelevated_Throws [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir(format: Gnu) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory(format: Gnu) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_Async(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_Async(format: Gnu) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir_Async(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir_Async(format: Gnu) [FAIL]

Sample Run #20220714.15.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Jul 15, 2022
@ilonatommy ilonatommy self-assigned this Jul 15, 2022
@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

PRs after merging with main started failing in runtime-staging job on System.Formats.Tar tests - platforms net7.0-Linux-Release-x64-Mono_Release_LinuxBionic-Ubuntu.1804.Amd64.Android.29.Open and net7.0-Linux-Release-arm64-Mono_Release_LinuxBionic-Windows.10.Amd64.Android.Open:

   Finished:    System.Formats.Tar.Tests
                 === TEST EXECUTION SUMMARY ===
                    System.Formats.Tar.Tests  Total: 871, Errors: 0, Failed: 10, Skipped: 8, Time: 8.624s
                 
                 
                 Std err:
                     System.Formats.Tar.Tests.TarReader_TarEntry_ExtractToFileAsync_Tests.SpecialFile_Unelevated_Throws_Async [FAIL]
                     System.Formats.Tar.Tests.TarReader_TarEntry_ExtractToFile_Tests.SpecialFile_Unelevated_Throws [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir(format: Gnu) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory(format: Gnu) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_Async(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_Async(format: Gnu) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir_Async(format: Pax) [FAIL]
                     System.Formats.Tar.Tests.TarFile_ExtractToDirectoryAsync_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory_LongBaseDir_Async(format: Gnu) [FAIL]

Sample Run #20220714.15.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@akoeplinger akoeplinger changed the title [wasm] Disabling Linux tests that fail on staging. Disabling Linux Bionic tests that fail on staging. Jul 15, 2022
@akoeplinger akoeplinger added test-bug Problem in test source code (most likely) and removed arch-wasm WebAssembly architecture area-Debugger-mono labels Jul 15, 2022
akoeplinger
akoeplinger reviewed Jul 15, 2022
View reviewed changes
src/libraries/System.Formats.Tar/tests/TarReader/TarReader.TarEntry.ExtractToFile.Tests.Unix.cs
@@ -9,7 +9,7 @@ namespace System.Formats.Tar.Tests
{
public partial class TarReader_TarEntry_ExtractToFile_Tests : TarTestsBase
{
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.tvOS)] // https://github.com/dotnet/runtime/issues/68360
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.tvOS & ~TestPlatforms.LinuxBionic)] // https://github.com/dotnet/runtime/issues/68360
[ConditionalFact(nameof(IsUnixButNotSuperUser))]
public void SpecialFile_Unelevated_Throws()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@directhex any idea why this might fail on Linux Bionic but apparently not on Android?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not offhand

@stephentoub stephentoub merged commit 5d8a81e into dotnet:main Jul 15, 2022
This was referenced Jul 18, 2022
Merged
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@directhex directhex directhex left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@ilonatommy ilonatommy

Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilonatommy @directhex @akoeplinger @stephentoub