Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize VN-based non-null knowledge better #69808

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Utilize VN-based non-null knowledge better #69808

merged 1 commit into from
Jun 4, 2022

Commits on May 28, 2022

  1. Utilize VN-based non-null knowledge better 

    Previously, global non-null assertion propagation would give up
on any non-"ADD(LCL_VAR, CONST)"-like trees. This is correct for
actual assertion-based propagation (since we record assertions
based on conservative VNs and those propagate only through locals),
but is unnecessarily conservative when it comes to utilizing
non-nullness provided by VN.

Fix this by moving the IR checks after the VN check.
    @SingleAccretion
    SingleAccretion committed May 28, 2022
    Configuration menu
    Copy the full SHA
    21ea0b2 View commit details
    Browse the repository at this point in the history