Utilize VN-based non-null knowledge better #69808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsPreviously, global non-null assertion propagation would give up on any non- Fix this by moving the IR checks after the VN check. We are expecting a moderate amount of positive diffs.
|
SingleAccretion
force-pushed
the
More-Non-Null-AssertionProp
branch
from
b535337
to
b874a31
Compare
|
@dotnet/jit-contrib |
Previously, global non-null assertion propagation would give up on any non-"ADD(LCL_VAR, CONST)"-like trees. This is correct for actual assertion-based propagation (since we record assertions based on conservative VNs and those propagate only through locals), but is unnecessarily conservative when it comes to utilizing non-nullness provided by VN. Fix this by moving the IR checks after the VN check.
SingleAccretion
force-pushed
the
More-Non-Null-AssertionProp
branch
from
b874a31
to
21ea0b2
Compare
jakobbotsch
approved these changes
Jun 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, global non-null assertion propagation would give up on any non-
ADD(LCL_VAR, CONST)-like trees. This is correct for actual assertion-based propagation (since we record assertions based on conservative VNs and those propagate only through locals), but is unnecessarily conservative when it comes to utilizing non-nullness provided by VN.Fix this by moving the IR checks after the VN check.
Diffs.